Skip to content

Commit

Permalink
fix: default octokit protocol option to undefined
Browse files Browse the repository at this point in the history
`null` does not get overwritten by _.defaults which `@octokit/rest` v15+ is using
  • Loading branch information
gr2m authored and pvdlg committed Mar 3, 2018
1 parent d3e5f66 commit 3fb0be0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/get-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ module.exports = ({
const {port, protocol, hostname} = githubUrl ? url.parse(githubUrl) : {};
const github = new Octokit({
port,
protocol: (protocol || '').split(':')[0] || null,
protocol: (protocol || '').split(':')[0] || undefined,
host: hostname,
pathPrefix: githubApiPathPrefix,
});
Expand Down

0 comments on commit 3fb0be0

Please sign in to comment.