add skipPace switch to android for Ukranian passports (do not merge yet)

[seshanthS]

Description

Add skipPace switch to android

Tested

Tested whether the value is passed to the native modules through logcat

How to QA

1. Scan the document normally - existing flow
2. Tap the (?) icon next to the Verify your Id text in the NFC Scan screen
3. Enable skip pace switch and scan the document. It could fail if its a new document.
4. Scan again with skip pace to false.

Summary by CodeRabbit

• New Features

  • Added a "Skip PACE" switch on the NFC method selection screen; users can toggle skipping PACE during document scanning.
  • The Skip PACE choice is now applied on Android and iOS scans for consistent behavior.

• Chores

  • App version bumped to 2.9.14.
  • Setup scripts updated to support cloning a specific commit for private modules.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

---

Note

Introduces a user-facing control and wires it through the scan pipeline; also hardens private module setup and updates versions.

• NFC UI/flow: Adds "Skip PACE" toggle in DocumentNFCMethodSelectionScreen and removes the old iOS-only skipPACE method entry; parameter is now forwarded in nfcScanner.ts and passportReader.ts for Android and iOS.
• Build/scripts: scripts/setup-private-modules.cjs can now checkout a specific commit when cloning; pins react-native-passport-reader to commit 99122a8.
• Versioning: Bumps Android versionCode to 139, app version to 2.9.14, and updates version.json Android build metadata.

^{Written by Cursor Bugbot for commit 17daae6. This will update automatically on new commits. Configure here.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds a UI "Skip PACE" toggle and threads a new skipPACE boolean from the UI through PassportReader and NFCScanner into the Android native scan call; also bumps Android/app and package versions and makes private-module cloning commit-aware.

Changes

Cohort / File(s)	Summary
UI / Navigation app/src/screens/documents/scanning/DocumentNFCMethodSelectionScreen.tsx	Removed static Skip PACE entry; added local skipPACE state with a Switch and forward params.skipPACE = true when navigating to the NFC scan screen.
Passport Reader (JS layer) app/src/integrations/nfc/passportReader.ts	Android flow destructures skipPACE = false and forwards skipPACE to the androidScan call.
NFC Scanner (JS layer) app/src/integrations/nfc/nfcScanner.ts	Android path now passes skipPACE: inputs.skipPACE ?? false into scanDocument, propagating the flag to native.
Android build / app metadata app/android/app/build.gradle, app/package.json, app/version.json	Bumped Android versionCode 136 → 139 and versionName "2.9.13" → "2.9.14"; app/package.json version 2.9.13 → 2.9.14; app/version.json android.build 138 → 139 and updated android.lastDeployed.
Setup scripts (CI/dev setup) app/scripts/setup-private-modules.cjs	PRIVATE_MODULES may include commit; clonePrivateRepo signature now accepts commit and performs a post-clone git checkout when present; setupPrivateModule updated to pass commit.

Sequence Diagram(s)

sequenceDiagram
  participant User as User (UI)
  participant UI as DocumentNFCMethodSelectionScreen
  participant PR as PassportReader (JS)
  participant NS as NFCScanner (JS)
  participant AN as Android Native

  User->>UI: toggle "Skip PACE" on
  UI->>PR: start scan with { skipPACE: true }
  PR->>NS: androidScan(..., { skipPACE: true })
  NS->>AN: scanDocument(..., { skipPACE: true })
  AN-->>NS: scan result
  NS-->>PR: result
  PR-->>UI: result / navigate/display

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• bump android version #1389 — touches Android versionCode/versionName and related version metadata (version bump alignment).
• bump android build version to 117 #1371 — updates app/version.json android build metadata (related build number/lastDeployed changes).
• Prep for v2.6.0 release #721 — modifies app version metadata including app/package.json and Android build fields (related version bumps).

Suggested labels

codex

Suggested reviewers

• transphorm

Poem

🔐 A tiny switch flips, PACE steps step aside,
From screen through JS to native it will glide.
A flag threaded true, a build nudged new,
Small change in flow — scans sail through. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description covers the required template sections with clear implementation details, testing approach via logcat, and comprehensive QA steps. The note about version bumps and private module changes is also documented.
Title check	✅ Passed	The title accurately describes the main change: adding a skipPACE switch to the Android implementation for Ukrainian passports.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}