-
Notifications
You must be signed in to change notification settings - Fork 211
SELF-1497: add keychain patch #1607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
926230b
add keychain patch - wip
seshanthS 4f83680
centralise useStrongbox flag usage
seshanthS 195e019
set allowBackup to false
seshanthS 2ad5535
Merge branch 'dev' into hotfix/keychain
transphorm dd35a9d
bump to version 2.9.12
transphorm a4d76d4
bump android build for 2.9.12
transphorm 519dcf4
Merge branch 'justin/bump-android-build-for-2_9_12' into hotfix/keychain
transphorm 7f4f3a1
improve keychain error detection
seshanthS cf815d3
Disable Strongbox by default
seshanthS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| // SPDX-FileCopyrightText: 2025 Social Connect Labs, Inc. | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| // NOTE: Converts to Apache-2.0 on 2029-06-11 per LICENSE. | ||
|
|
||
| import type { SetOptions } from 'react-native-keychain'; | ||
|
|
||
| /** | ||
| * Extended SetOptions with useStrongBox property added by our patch. | ||
| * Use this type when you need the useStrongBox option for Android keystore. | ||
| */ | ||
| export type ExtendedSetOptions = SetOptions & { | ||
| /** | ||
| * Whether to attempt StrongBox-backed key generation on Android. | ||
| * When true (default), the library will try to use StrongBox hardware | ||
| * security module if available, falling back to regular secure hardware. | ||
| * When false, StrongBox is skipped and regular secure hardware is used directly. | ||
| * @platform Android | ||
| * @default true | ||
| */ | ||
| useStrongBox?: boolean; | ||
| }; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential race condition with store rehydration.
useSettingStore.getState().useStrongBoxaccesses the persisted store synchronously. IfcreateKeychainOptionsis called early during app startup before AsyncStorage rehydration completes, it may read the defaulttrueinstead of the user's persisted preference.Consider checking
useSettingStore.persist.hasHydrated()or subscribing toonRehydrateStorageif this function can be invoked during initial app boot.🛠️ Potential safeguard
📝 Committable suggestion
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s acceptable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seshanthS, understood. I've noted your decision. The implementation will proceed with the current approach.🧠 Learnings used