Skip to content

Conversation

@transphorm
Copy link
Member

Motivation

  • Align the ProveScreen UI with the DocumentSelectorForProvingScreen design while preserving all existing proving logic and analytics.
  • Preserve the user's scroll position when navigating from the document selector to the proving screen so users do not need to re-scroll.
  • Remove duplicated disclosure formatting by extracting a shared disclosure utility used by both screens.
  • Replace the BottomActionBar approve layout with the existing hold-to-verify control while keeping the proving state machine intact.

Description

  • Added app/src/utils/disclosureUtils.ts with getDisclosureItems and migrated both screens to consume it to avoid duplication.
  • Added app/src/components/proof-request/BottomVerifyBar.tsx which wraps HeldPrimaryButtonProveScreen and exported it from the proof-request index.
  • Extended ProofRequestCard to accept scroll control props (onScroll, scrollViewRef, onContentSizeChange, onLayout, initialScrollOffset) and wired them to the internal ScrollView to support restoring scroll position.
  • Updated navigation types to accept an optional scrollOffset for the Prove route and changed DocumentSelectorForProvingScreen to track scroll offset and pass it when navigating; refactored ProveScreen to use ProofRequestCard, DisclosureItem, ConnectedWalletBadge, WalletAddressModal, and BottomVerifyBar while preserving all existing effects, proving store logic, and analytics calls.

Testing

  • No automated tests were run in this environment.
  • Before creating a PR run yarn nice and yarn types to validate formatting and types locally.
  • Run unit tests with yarn test and build with yarn build as part of pre-PR/CI validation.
  • For mobile UI verification run platform builds or emulators using yarn ios or yarn android as appropriate.

Codex Task

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)
  • main
  • dev
  • staging

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@transphorm transphorm merged commit 99d200e into justin/self-1754-proving-screen-selective-disclosure Jan 8, 2026
6 checks passed
@transphorm transphorm deleted the codex/refactor-provescreen-to-match-design branch January 8, 2026 15:57
transphorm added a commit that referenced this pull request Jan 9, 2026
* add document selector test screen

* clean up mock docs

* update selection options

* Add DocumentSelectorForProving screen and route proof flows through it (#1555)

* Add document selector to proving flow

* fix formatting

* improvements

* redirect user to document not found screen when no documents

* option flow tweaks and tests

* wip tweaks

* fix scrollview bottom padding (#1556)

* tighten up selection text

* create inerstitial

* save wip

* remove not accepted state

* save wip design

* formatting

* update design

* update layout

* Update proving flow tests (#1559)

* Refactor ProveScreen to ProofRequestCard layout and preserve scroll position (#1560)

* Refactor prove screen layout

* fix: amount of hooks rendered needs to be the same for all variants

* long URL ellipsis

* keep titles consistent

* lint

---------

Co-authored-by: Leszek Stachowski <[email protected]>

* wip fix tests

* fix tests

* formatting

* agent feedback

* fix tests

* save wip

* remove text

* fix types

* save working header update

* no transition

* cache document load for proving flow

* save fixes

* small fixes

* match disclosure text

* design updates

* fix approve flow

* fix document type flash

* add min height so text doesn't jump

* update lock

* formatting

* save refactor wip

* don't enable euclid yet

* fix tests

* fix staleness check

* fix select box description

* remove id selector screen

* vertically center

* button updates

* Remove proving document cache (#1567)

* formatting

---------

Co-authored-by: Leszek Stachowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants