remove option to change target bump build pr branch. default to dev #1550

transphorm · 2026-01-06T20:47:58Z

Description

A brief description of the changes, what and how is being changed.

Tested

Explain how the change has been tested (for example by manual testing, unit tests etc) or why it's not necessary (for example version bump).

How to QA

How can the change be tested in a repeatable manner?

Summary by CodeRabbit

Chores
- Standardized the mobile deployment workflow to consistently target the dev branch for all version bumps and releases, removing customization options to ensure uniform behavior across the deployment process.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-06T20:48:21Z

📝 Walkthrough

Walkthrough

The PR simplifies the mobile deployment GitHub Actions workflow by removing the customizable bump_target_branch input and hardcoding version-bump operations to always target the dev branch across PR creation, branch checkout, and release tagging steps.

Changes

Cohort / File(s)	Summary
Workflow Configuration Simplification `.github/workflows/mobile-deploy.yml`	Removed `bump_target_branch` input parameter; replaced all references to `inputs.bump_target_branch` with hardcoded `"dev"` string in version-bump PR checkout, creation, and release tagging steps; updated comments to reflect dev as the single target branch

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly Related PRs

code rabbit feedback for staging auto deploy logic #1255: Modifies version-bump PR and release tagging flows with overlapping workflow changes
staging: test mobile deploy auto pull request (#1234) #1237: Previously added the create-version-bump-pr flow targeting dev/staging branches
fix mobile deploy auto pr; update build versions #1202: Earlier change that transitioned bump PRs to target the dev branch

Suggested Labels

skip-deploy

Suggested Reviewers

remicolin

Poem

🔄 One branch to rule them all,
Dev stands tall, no more the call
For custom paths that twist and wind—
Simplicity, at last we find! ✨

Pre-merge checks

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description only contains template placeholders with no actual content filled in. All required sections (Description, Tested, How to QA) are empty.	Provide concrete details: what changes were made and why, how the workflow changes were tested, and steps to verify the fix works as intended.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: removing the ability to customize the version-bump target branch and defaulting to dev.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43fb39d and 764845a.

📒 Files selected for processing (1)

.github/workflows/mobile-deploy.yml

🧰 Additional context used

📓 Path-based instructions (2)

.github/workflows/*.yml

📄 CodeRabbit inference engine (.cursor/rules/test-memory-optimization.mdc)

Add a CI fast-fail check step that runs the validation script to detect nested require() patterns before test execution to prevent out-of-memory pipeline failures

Files:

.github/workflows/mobile-deploy.yml

.github/workflows/**/*.{yaml,yml}

📄 CodeRabbit inference engine (AGENTS.md)

Use shared composite actions from .github/actions for CI caching (cache-yarn for Yarn dependencies, cache-bundler for Ruby gems, cache-gradle for Gradle, cache-pods for CocoaPods) instead of calling actions/cache directly

Files:

.github/workflows/mobile-deploy.yml

🧠 Learnings (12)

📓 Common learnings

Learnt from: transphorm
Repo: selfxyz/self PR: 1446
File: .github/workflows/mobile-bundle-analysis.yml:117-117
Timestamp: 2025-11-22T23:16:26.719Z
Learning: In the selfxyz/self repository, for mobile workflows (bundle analysis, deployment, CI/CD):
- Both iOS and Android builds now cache Ruby gems at the unified path `app/vendor/bundle`
- The previous separate paths (app/ios/vendor/bundle for iOS) have been deprecated in favor of this unified approach

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/ios/**/* : Ensure iOS build succeeds with `yarn ios` before creating a PR

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/{package.json,app/app.json} : Bump version in `package.json` and `app.json` before deployment

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/android/**/* : Ensure Android build succeeds with `yarn android` before creating a PR

Learnt from: transphorm
Repo: selfxyz/self PR: 919
File: .github/workflows/mobile-ci.yml:437-439
Timestamp: 2025-09-06T02:14:42.185Z
Learning: When infrastructure issues like NDK version misalignment are identified during feature PRs, the team prefers to defer these to separate follow-up PRs to maintain focused scope and avoid scope creep.

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Ensure no breaking changes to public API or document them properly

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-11-22T23:16:26.719Z

Learnt from: transphorm
Repo: selfxyz/self PR: 1446
File: .github/workflows/mobile-bundle-analysis.yml:117-117
Timestamp: 2025-11-22T23:16:26.719Z
Learning: In the selfxyz/self repository, for mobile workflows (bundle analysis, deployment, CI/CD):
- Both iOS and Android builds now cache Ruby gems at the unified path `app/vendor/bundle`
- The previous separate paths (app/ios/vendor/bundle for iOS) have been deprecated in favor of this unified approach

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Before committing changes, ensure the build succeeds by running `yarn build`

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:04.954Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/{package.json,app/app.json} : Bump version in `package.json` and `app.json` before deployment

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Before creating a PR, ensure `yarn build` succeeds (package builds correctly)

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Before creating a PR, ensure `yarn types` passes (TypeScript validation)

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Before committing changes, ensure TypeScript types are valid by running `yarn types`

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:04.954Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/android/**/* : Ensure Android build succeeds with `yarn android` before creating a PR

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:35.354Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:35.354Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{ts,tsx} : Run `yarn build` to build the package for distribution

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:04.954Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Applies to app/ios/**/* : Ensure iOS build succeeds with `yarn ios` before creating a PR

Applied to files:

.github/workflows/mobile-deploy.yml

📚 Learning: 2025-12-25T19:19:04.954Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-12-25T19:19:04.954Z
Learning: Ensure CI pipeline passes all stages after PR creation

Applied to files:

.github/workflows/mobile-deploy.yml

⏰ Context from checks skipped due to timeout of 300000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: type-check

🔇 Additional comments (4)

.github/workflows/mobile-deploy.yml (4)

19-19: Documentation updated correctly.

The comment accurately reflects that version bump PRs now always target the dev branch.

410-410: Consistent hardcoding of target branch.

The TARGET_BRANCH variable is correctly set to dev, which aligns with the checkout target above and is used consistently throughout the PR creation logic.

486-487: Consistent implementation for release tagging.

The release tags job correctly checks out the dev branch, consistent with the version bump PR job. The same validation concern about the dev branch existence applies here as well (see comment on lines 297-298).

297-298: The lines referenced in this review do not contain the code being critiqued.

Lines 297-298 validate the .nvmrc file for Node.js version configuration, not branch checkout. The actual hardcoded dev branch checkouts occur at lines 1298 and 1487 in the create-version-bump-pr and create-release-tags jobs. If validating branch existence is a concern, it should reference those lines instead.

Likely an incorrect or invalid review comment.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…1550)

remove option to change target bump build pr branch. default to dev

764845a

transphorm merged commit d02a730 into dev Jan 6, 2026
15 checks passed

transphorm deleted the justin/remove-mobile-deploy-branch-targeting branch January 6, 2026 20:59

jcortejoso pushed a commit that referenced this pull request Jan 15, 2026

remove option to change target bump build pr branch. default to dev (#…

d8b3b9c

…1550)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

remove option to change target bump build pr branch. default to dev #1550

remove option to change target bump build pr branch. default to dev #1550

Uh oh!

transphorm commented Jan 6, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 6, 2026 •

edited

Loading

Walkthrough

Changes

Estimated Code Review Effort

Possibly Related PRs

Suggested Labels

Suggested Reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

remove option to change target bump build pr branch. default to dev #1550

remove option to change target bump build pr branch. default to dev #1550

Uh oh!

Conversation

transphorm commented Jan 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Tested

How to QA

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated Code Review Effort

Possibly Related PRs

Suggested Labels

Suggested Reviewers

Poem

Pre-merge checks

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

transphorm commented Jan 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 6, 2026 •

edited

Loading