Use eslint to run prettier #1463

transphorm · 2025-12-03T06:36:40Z

Summary by CodeRabbit

Chores
- Added postinstall and test-run scripts; removed duplicate script entries.
- Standardized and simplified formatting/linting scripts across packages (format → yarn nice; nice → yarn lint:fix).
- Reintroduced SDK package entry points for CommonJS, ESM and TypeScript (main/module/types) and added top-level metadata fields.
- Minor cleanup of unused imports in service utilities.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-03T06:36:45Z

Walkthrough

This PR consolidates and simplifies npm scripts across multiple packages (app, circuits, mobile SDKs), adds a postinstall hook in app/package.json, and restores explicit CommonJS/ESM/type entry fields in sdk/sdk-common/package.json. One duplicate script entry was removed and a minor import was deleted in a points utility.

Changes

Cohort / File(s)	Summary
App scripts & postinstall `app/package.json`	Added `postinstall` script; added `jest:run`; removed duplicate `jest:run` entry; updated `nice` script to remove `postinstall` and `yarn fmt:fix` from its chain.
Mobile SDK scripts `packages/mobile-sdk-alpha/package.json`, `packages/mobile-sdk-demo/package.json`	`format` now delegates to `yarn nice`; `nice` simplified to `yarn lint:fix` (removed combined fmt step and conditional shell logic).
Circuits scripts reorder `circuits/package.json`	Repositioned `test-gcp-jwt-verifier` within scripts section (no functional change).
SDK entry points & metadata `sdk/sdk-common/package.json`	Reintroduced/added `main`, `module`, `types`, `type`, and top-level fields (`keywords`, `license`, `author`) and reordered some fields; `build` now precedes `test` in scripts.
Code cleanup `app/src/services/points/utils.ts`	Removed unused import `POINTS_TOKEN_CONTRACT_ADDRESS`, retaining only `POINTS_API_BASE_URL`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

Inspect app/package.json postinstall: ensure patch-package invocation and environment assumptions (node/yarn versions, CI) are correct and safe.
Verify sdk/sdk-common main/module/types paths exist in build outputs and won't break downstream consumers (packaging/exports).
Confirm removing yarn fmt:fix from nice across mobile packages doesn't leave formatting regressions in CI or prepublish checks.

Possibly related PRs

chore: fix yarn format #1009 — related script changes (format/nice and conditional SKIP_BUILD_DEPS handling) across multiple packages.
dev fixes for release 2.9.1 #1428 — related updates to app/package.json test/postinstall/jest scripts.
Fix/jwt output #1452 — related edits to circuits/package.json test-gcp-jwt-verifier script placement.

Suggested labels

codex

Suggested reviewers

motemotech
remicolin
shazarre

Poem

Scripts tidy up and parcels mend,
Entry points set for builds to send,
Postinstall readies patched-up art,
Small imports trimmed to play their part,
A cleaner repo — quiet cartography 🎉

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'Use eslint to run prettier' is vague and misleading. The actual changes involve consolidating and reorganizing package.json scripts across multiple packages, removing duplicate entries, and updating build/test workflow scripts—not implementing ESLint to run Prettier.	Revise the title to accurately reflect the main changes, such as 'Consolidate and reorganize package.json scripts across monorepo packages' or 'Clean up duplicate package.json scripts and simplify workflow commands'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch justin/minor-house-cleaning

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 64ab5fc and 840d75b.

⛔ Files ignored due to path filters (2)

app/Gemfile.lock is excluded by !**/*.lock
app/ios/Podfile.lock is excluded by !**/*.lock

📒 Files selected for processing (6)

app/package.json (2 hunks)
app/src/services/points/utils.ts (1 hunks)
circuits/package.json (1 hunks)
packages/mobile-sdk-alpha/package.json (1 hunks)
packages/mobile-sdk-demo/package.json (1 hunks)
sdk/sdk-common/package.json (2 hunks)

🧰 Additional context used

📓 Path-based instructions (14)

**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{js,jsx,ts,tsx}: NEVER log sensitive data including PII (names, DOB, passport numbers, addresses), credentials, tokens, API keys, private keys, or session identifiers.
ALWAYS redact/mask sensitive fields in logs using consistent patterns (e.g., ***-***-1234 for passport numbers, J*** D*** for names).

Files:

app/src/services/points/utils.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursorrules)

**/*.{ts,tsx,js,jsx}: Use React Navigation with createStaticNavigation for type-safe navigation in React Native applications.
Implement platform-specific handling with Platform.OS === 'ios' ? 'iOS' : 'Android' checks before platform-specific code in React Native.
Initialize native modules with initializeNativeModules() before any native operations in React Native.
Implement lazy loading for screens using React.lazy() in React Native applications.
Implement custom modal system with useModal hook and callback registry in React Native.
Integrate haptic feedback using useHapticNavigation hook in React Native navigation.
Use platform-specific initial routes: web uses 'Home', mobile uses 'Splash' in React Navigation.
Use Zustand for global state management in React Native applications.
Use custom hooks for complex state (useModal, useHapticNavigation) instead of inline logic.
Use AsyncStorage for simple data, SQLite for complex data, and Keychain for sensitive data in React Native.
Use @/ alias for src imports and @tests/ alias for test imports in TypeScript/JavaScript files.
Use conditional rendering with Platform.OS for platform-specific code in React Native.
Use Tamagui for UI components in React Native applications.
Do not log sensitive data in production, including identity verification and passport information.
Use Keychain for secure storage of sensitive data in React Native.
Implement proper cleanup of sensitive data after use.
Implement certificate validation for passport data verification.
Always use try-catch for async operations in React Native and TypeScript code.
Implement graceful degradation when native modules fail in React Native.
Provide user-friendly error messages in UI and error handlers.
Lazy load screens and components to optimize bundle size in React Native.
Prevent memory leaks in native modules in React Native.

Files:

app/src/services/points/utils.ts

**/*.{tsx,jsx,ts,js}

📄 CodeRabbit inference engine (.cursorrules)

Implement proper cleanup in useEffect and component unmount hooks in React.

Files:

app/src/services/points/utils.ts

**/{mobile,client,app,time,verification}/**/*.{ts,tsx,js,swift,kt}

📄 CodeRabbit inference engine (.cursor/rules/compliance-verification.mdc)

Use server-signed time tokens or chain block timestamps for trusted time in mobile clients, do not trust device wall-clock alone

Files:

app/src/services/points/utils.ts

**/{mobile,client,app,proof,zk}/**/*.{ts,tsx,js,swift,kt}

📄 CodeRabbit inference engine (.cursor/rules/compliance-verification.mdc)

**/{mobile,client,app,proof,zk}/**/*.{ts,tsx,js,swift,kt}: Include trusted time anchor in proof generation and verify time anchor authenticity before proof generation in mobile implementations
Achieve proof generation in <60 seconds on mid-tier mobile devices

Files:

app/src/services/points/utils.ts

app/src/**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/mobile-sdk-migration.mdc)

Use module mapping @/ → src/ and @tests/ → tests/src/ in app Jest configuration

Files:

app/src/services/points/utils.ts

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/mobile-sdk-migration.mdc)

**/*.{ts,tsx,js}: Never log PII, credentials, or private keys in production code; use DEBUG_SECRETS_TOKEN flag for debug-level secrets
Use consistent redaction patterns for sensitive fields in logs and test data

Files:

app/src/services/points/utils.ts

app/src/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/mobile-sdk-migration.mdc)

Update app to consume mobile-sdk-alpha modules after migration and validate all existing app tests pass

Files:

app/src/services/points/utils.ts

app/**/*.{ts,tsx,js,jsx,json,yml,yaml}

📄 CodeRabbit inference engine (app/AGENTS.md)

Ensure yarn nice passes (fixes linting and formatting) before creating a PR

Files:

app/src/services/points/utils.ts
app/package.json

app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (app/AGENTS.md)

Ensure yarn types passes (TypeScript validation) before creating a PR

Files:

app/src/services/points/utils.ts

app/**/*.{ts,tsx,js,jsx,swift,kt,java}

📄 CodeRabbit inference engine (app/AGENTS.md)

app/**/*.{ts,tsx,js,jsx,swift,kt,java}: Flag security-sensitive operations and note performance implications in code comments
Ensure no sensitive data (PII, credentials, tokens) is present in logs

Files:

app/src/services/points/utils.ts

app/src/**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

app/src/**/*.{ts,tsx,js,jsx}: Review React Native TypeScript code for:

Component architecture and reusability

State management patterns

Performance optimizations

TypeScript type safety

React hooks usage and dependencies

Navigation patterns

Files:

app/src/services/points/utils.ts

packages/mobile-sdk-alpha/**/*.{js,ts,tsx,json,md,yml,yaml}

📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)

Use Prettier for code formatting with root Prettier and EditorConfig settings

Files:

packages/mobile-sdk-alpha/package.json

packages/mobile-sdk-alpha/**/package.json

📄 CodeRabbit inference engine (packages/mobile-sdk-alpha/AGENTS.md)

packages/mobile-sdk-alpha/**/package.json: Ensure exports are properly configured before publishing the package
Verify package conditions are valid before publishing

Files:

packages/mobile-sdk-alpha/package.json

🧠 Learnings (42)

📓 Common learnings

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/**/*.{ts,tsx,js,jsx,json,yml,yaml} : Ensure `yarn nice` passes (fixes linting and formatting) before creating a PR

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Before committing, run linting and formatting fixes with `yarn workspaces foreach -A -p -v --topological-dev --since=HEAD run nice --if-present`.

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{js,ts,tsx,json,md,yml,yaml} : Use Prettier for code formatting with root Prettier and EditorConfig settings

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Before committing changes, run `yarn nice` to fix linting and formatting issues automatically

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Ensure CI pipeline passes all stages and no new linting/formatting issues are introduced after PR creation.

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Use Prettier configuration from `.prettierrc` files and follow `.editorconfig` for line endings and indentation.

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/artifacts/**/*.{ts,tsx} : Migrate artifact management from app/src/utils/ to packages/mobile-sdk-alpha/src/artifacts/ with tests for manifest validation, CDN downloads, signature verification, and storage

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/protocol/**/*.{ts,tsx} : Migrate protocol synchronization from app/src/utils/ to packages/mobile-sdk-alpha/src/protocol/ with tests for tree fetching, TTL caching, rate limiting, and memory bounds

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export all new migrated modules via packages/mobile-sdk-alpha/src/index.ts and document them in packages/mobile-sdk-alpha/README.md

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure exports are properly configured before publishing the package

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/**/*.{ts,tsx} : Ensure all exports in migrated modules support tree shaking for optimal bundle size

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/processing/**/*.{ts,tsx} : Migrate MRZ processing helpers from app/src/utils/ to packages/mobile-sdk-alpha/src/processing/ with comprehensive tests for MRZ parsing and cross-platform compatibility

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/demo/**/*.{ts,tsx,js,jsx} : Create an in-SDK lightweight demo in packages/mobile-sdk-alpha/demo/ using embedded React Native with MRZ flow and theming hooks integration

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/attestation/**/*.{ts,tsx} : Migrate attestation verification from app/src/utils/ to packages/mobile-sdk-alpha/src/attestation/ with tests for PCR0 validation and certificate chain validation

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/attestation/**/*.{ts,tsx} : Migrate attestation verification from app/src/utils/ to packages/mobile-sdk-alpha/src/attestation/ with tests for PCR0 validation and certificate chain validation

Applied to files:

circuits/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/artifacts/**/*.{ts,tsx} : Migrate artifact management from app/src/utils/ to packages/mobile-sdk-alpha/src/artifacts/ with tests for manifest validation, CDN downloads, signature verification, and storage

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/crypto/**/*.{ts,tsx} : Migrate crypto adapters from app/src/utils/ to packages/mobile-sdk-alpha/src/crypto/ with tests for WebCrypto vs noble/* fallback and timing-safe comparisons

Applied to files:

circuits/package.json
app/src/services/points/utils.ts
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/protocol/**/*.{ts,tsx} : Migrate protocol synchronization from app/src/utils/ to packages/mobile-sdk-alpha/src/protocol/ with tests for tree fetching, TTL caching, rate limiting, and memory bounds

Applied to files:

circuits/package.json
app/src/services/points/utils.ts
packages/mobile-sdk-demo/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/proving/**/*.{ts,tsx} : Migrate proof input generation from app/src/utils/proving/ to packages/mobile-sdk-alpha/src/proving/ with tests for register, disclose, and TEE input generation

Applied to files:

circuits/package.json
app/src/services/points/utils.ts

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/processing/**/*.{ts,tsx} : Migrate MRZ processing helpers from app/src/utils/ to packages/mobile-sdk-alpha/src/processing/ with comprehensive tests for MRZ parsing and cross-platform compatibility

Applied to files:

circuits/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/validation/**/*.{ts,tsx} : Migrate document validation logic from app/src/utils/ to packages/mobile-sdk-alpha/src/validation/ with unit tests for each validation rule and edge cases

Applied to files:

circuits/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/tests/**/*.{ts,tsx,test.ts,test.tsx} : Create tests BEFORE migrating logic to verify functionality works correctly in the mobile-sdk-alpha package

Applied to files:

circuits/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/tee/**/*.{ts,tsx} : Migrate TEE session management from app/src/utils/ to packages/mobile-sdk-alpha/src/tee/ with tests for WebSocket handling, abort, timeout, and lifecycle events

Applied to files:

circuits/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/**/*.{ts,tsx,js,jsx,json,yml,yaml} : Ensure `yarn nice` passes (fixes linting and formatting) before creating a PR

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/**/*.{test,spec}.{ts,tsx,js,jsx} : Ensure `yarn test` passes (unit tests) before creating a PR

Applied to files:

circuits/package.json

📚 Learning: 2025-11-25T14:08:11.887Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Before committing, run linting and formatting fixes with `yarn workspaces foreach -A -p -v --topological-dev --since=HEAD run nice --if-present`.

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Run `yarn test:build` command to validate tests, build dependencies, types, and bundle analysis in both app and mobile-sdk-alpha directories

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/tests/**/*.{test.ts,test.tsx,spec.ts,spec.tsx} : Use Vitest for testing in the mobile-sdk-alpha package with Node environment configured in vitest.config.ts

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Before committing changes, run `yarn test` to ensure all tests pass

Applied to files:

circuits/package.json
app/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Before committing changes, run `yarn nice` to fix linting and formatting issues automatically

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:11.887Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Before committing, build all workspaces except `contracts` using `yarn build`, and compile Solidity contracts with `yarn workspace selfxyz/contracts build`.

Applied to files:

circuits/package.json
app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/**/*.{ts,tsx} : Ensure `yarn types` passes (TypeScript validation) before creating a PR

Applied to files:

circuits/package.json
packages/mobile-sdk-alpha/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to app/**/*.{test.js,test.ts,test.tsx,spec.js,spec.ts,spec.tsx} : Use Jest for testing in the app directory with React Native preset configured in jest.config.cjs

Applied to files:

circuits/package.json
app/package.json

📚 Learning: 2025-08-25T14:25:57.586Z

Learnt from: aaronmgdr
Repo: selfxyz/self PR: 951
File: app/src/providers/authProvider.web.tsx:17-18
Timestamp: 2025-08-25T14:25:57.586Z
Learning: The selfxyz/mobile-sdk-alpha/constants/analytics import path is properly configured with SDK exports, Metro aliases, and TypeScript resolution. Import changes from @/consts/analytics to this path are part of valid analytics migration, not TypeScript resolution issues.

Applied to files:

app/src/services/points/utils.ts
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/**/*.{ts,tsx} : Ensure all exports in migrated modules support tree shaking for optimal bundle size

Applied to files:

app/src/services/points/utils.ts
packages/mobile-sdk-alpha/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/index.ts : Re-export all new migrated modules via packages/mobile-sdk-alpha/src/index.ts and document them in packages/mobile-sdk-alpha/README.md

Applied to files:

app/src/services/points/utils.ts
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Before committing changes, run `yarn build` to ensure the build succeeds

Applied to files:

app/package.json
packages/mobile-sdk-alpha/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{js,ts,tsx,json,md,yml,yaml} : Use Prettier for code formatting with root Prettier and EditorConfig settings

Applied to files:

app/package.json
packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Before committing changes, run `yarn types` to check TypeScript types across the codebase

Applied to files:

app/package.json
packages/mobile-sdk-alpha/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/ios/** : iOS build must succeed via `yarn ios` command in target environments

Applied to files:

app/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/android/** : Android build must succeed via `yarn android` command in target environments

Applied to files:

app/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:08:23.106Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: app/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:23.106Z
Learning: Applies to app/web/** : Web build must succeed via `yarn web` command in target environments

Applied to files:

app/package.json
packages/mobile-sdk-alpha/package.json

📚 Learning: 2025-11-25T14:08:11.887Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Run `yarn install` once before running any other commands to install root dependencies and set up husky hooks.

Applied to files:

app/package.json

📚 Learning: 2025-11-25T14:08:11.887Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Ensure Node.js 22.x is installed as specified in `.nvmrc`, then run `nvm use`, `corepack enable && corepack prepare yarnstable --activate`, and verify with `node -v && yarn -v`.

Applied to files:

app/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/**/*.{ts,tsx} : Test platform-specific code paths for React Native (iOS and Android) and web implementations

Applied to files:

app/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to app/src/**/*.{ts,tsx,js} : Use module mapping `@/` → `src/` and `tests/` → `tests/src/` in app Jest configuration

Applied to files:

app/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Ensure exports are properly configured before publishing the package

Applied to files:

packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/package.json : Verify package conditions are valid before publishing

Applied to files:

packages/mobile-sdk-alpha/package.json
packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/**/*.{ts,tsx} : Provide comprehensive TypeScript type definitions and maintain type safety across SDK exports

Applied to files:

packages/mobile-sdk-alpha/package.json
sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:08:11.887Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:11.887Z
Learning: Before committing, run type-checking across the repo with `yarn types`.

Applied to files:

packages/mobile-sdk-alpha/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/demo/**/*.{ts,tsx,js,jsx} : Create an in-SDK lightweight demo in packages/mobile-sdk-alpha/demo/ using embedded React Native with MRZ flow and theming hooks integration

Applied to files:

packages/mobile-sdk-demo/package.json

📚 Learning: 2025-11-25T14:07:55.507Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: .cursor/rules/mobile-sdk-migration.mdc:0-0
Timestamp: 2025-11-25T14:07:55.507Z
Learning: Applies to packages/mobile-sdk-alpha/src/**/*.{ts,tsx} : Use async/await patterns for non-blocking operations throughout SDK modules

Applied to files:

sdk/sdk-common/package.json

📚 Learning: 2025-08-01T17:11:39.232Z

Learnt from: transphorm
Repo: selfxyz/self PR: 823
File: common/package.json:21-60
Timestamp: 2025-08-01T17:11:39.232Z
Learning: Explicit export mappings in package.json exports field provide better tree shaking than wildcard patterns because they enable easier static analysis by bundlers, allowing for more precise dependency graph understanding and better dead code elimination.

Applied to files:

sdk/sdk-common/package.json

📚 Learning: 2025-07-28T19:18:48.270Z

Learnt from: transphorm
Repo: selfxyz/self PR: 795
File: app/src/screens/prove/ProveScreen.tsx:5-5
Timestamp: 2025-07-28T19:18:48.270Z
Learning: The import path 'selfxyz/common/utils/scope' is valid when the common package has a "./utils/*" export mapping in package.json, even if ESLint shows resolution errors before the package is built. The package.json exports field properly maps "./utils/*" to the compiled files in dist/.

Applied to files:

sdk/sdk-common/package.json

📚 Learning: 2025-11-25T14:08:51.177Z

Learnt from: CR
Repo: selfxyz/self PR: 0
File: packages/mobile-sdk-alpha/AGENTS.md:0-0
Timestamp: 2025-11-25T14:08:51.177Z
Learning: Applies to packages/mobile-sdk-alpha/**/*.{js,ts,tsx} : Configure ESLint with TypeScript-specific rules

Applied to files:

sdk/sdk-common/package.json

🔇 Additional comments (5)

packages/mobile-sdk-alpha/package.json (1)

129-145: Scripts delegation from format → nice → lint:fix looks consistent

format now simply delegates to nice, and nice runs lint:fix with no recursion or surprising side effects; this matches the repo’s “use eslint to run prettier” direction and keeps the workflow simple.

circuits/package.json (1)

20-38: New test-gcp-jwt-verifier script is wired correctly

The new script cleanly reuses test-base with a scoped pattern and --exit; no conflicts with existing scripts or test flows.

app/src/services/points/utils.ts (1)

9-13: Import cleanup is safe and reduces noise

Dropping the unused POINTS_TOKEN_CONTRACT_ADDRESS import while keeping POINTS_API_BASE_URL matches the actual usage and slightly tightens the module.

packages/mobile-sdk-demo/package.json (1)

7-29: Formatting scripts now consistently funnel through lint:fix

format delegating to nice, and nice running lint:fix, mirrors the SDK package and centralizes fix behavior without introducing loops or breaking existing commands.

app/package.json (1)

27-64: Script rewiring looks good; confirm eslint→prettier integration so nice still formats

Moving patch‑package into postinstall, adding an explicit jest:run, and simplifying nice to build:deps + imports:fix && lint:fix all make sense. The only thing to double‑check is that lint:fix actually runs Prettier (e.g., via eslint-plugin-prettier and a prettier/prettier rule); otherwise yarn nice would stop applying Prettier formatting as implied by the repo guidelines.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

transphorm · 2025-12-03T14:56:00Z

@coderabbitai full review

coderabbitai · 2025-12-03T14:56:07Z

✅ Actions performed

Full review triggered.

transphorm added 2 commits December 2, 2025 22:30

sort packages

5c2af3e

consolidate prettier under eslint fix

8d093a2

transphorm changed the base branch from main to dev December 3, 2025 06:36

transphorm marked this pull request as ready for review December 3, 2025 06:37

lint and lock files

840d75b

transphorm temporarily deployed to development December 3, 2025 06:49 — with GitHub Actions Inactive

transphorm merged commit 967ce31 into dev Dec 3, 2025
30 checks passed

transphorm deleted the justin/minor-house-cleaning branch December 3, 2025 15:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use eslint to run prettier #1463

Use eslint to run prettier #1463

Uh oh!

transphorm commented Dec 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Dec 3, 2025 •

edited

Loading

Uh oh!

transphorm commented Dec 3, 2025

Uh oh!

coderabbitai bot commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Use eslint to run prettier #1463

Use eslint to run prettier #1463

Uh oh!

Conversation

transphorm commented Dec 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

transphorm commented Dec 3, 2025

Uh oh!

coderabbitai bot commented Dec 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

transphorm commented Dec 3, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 3, 2025 •

edited

Loading