Release to Staging - 2025-11-21 #1444
Conversation
* Recovery: reduce fingerprint popup count * add await to reStorePassportDataWithRightCSCA
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on December 17
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| const passportDataAndSecret = await loadPassportDataAndSecret(); | ||
| if (!passportDataAndSecret) { | ||
| const passportData = await loadPassportData(); | ||
| const secret = getPrivateKeyFromMnemonic(slimMnemonic); |
There was a problem hiding this comment.
Bug: Recovery derivation uses parameter instead of stored mnemonic
The new code derives the private secret directly from the user-provided mnemonic parameter instead of loading the stored mnemonic from keychain like the old code did. If any discrepancy exists between the parameter and what was actually stored by restoreAccountFromMnemonic (due to encoding, normalization, or storage issues), the derived secret will be incorrect and cause authentication to fail. The old approach validated consistency by loading from the authoritative stored source.
There was a problem hiding this comment.
the goal here is to reduce the amount of mnemonic verifications that the user needs to perform
|
this pull request is stale. closing in favor of the newer pr to update |
🚀 Weekly Release to Staging
Release Date: November 21, 2025
Release Branch:
release/staging-2025-11-21This automated PR promotes a snapshot of
devtostagingfor testing.What's Included
All commits merged to
devup to the branch creation time.Note: This PR uses a dedicated release branch, so new commits to
devwill NOT automatically appear here.Review Checklist
Next Steps
After merging, the staging environment will be updated. A production release PR will be created on Sunday.
This PR was automatically created by the Release Calendar workflow on November 21, 2025
Note
Derives private key directly from mnemonic and updates recovery flows to load/parse passport data separately, adjust CSCA handling, and improve analytics.
loadPassportDataAndSecretwithloadPassportDataand derivesecretviagetPrivateKeyFromMnemonic(...).passportDataJSON before use and pass parsed data toisUserRegisteredWithAlternativeCSCA(...)andreStorePassportDataWithRightCSCA(...).no_passport_data_or_secret,document_not_registered) and includehasCSCAflag.getPrivateKeyFromMnemonic(mnemonic)utility usingethers.HDNodeWallet.fromPhrase.unsafe_getPrivateKeyto usegetPrivateKeyFromMnemonic(...).Written by Cursor Bugbot for commit fb4cd92. This will update automatically on new commits. Configure here.