Implement HDFS partitioned parquet storage for SS #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: masih <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (10.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
- Coverage 63.60% 63.41% -0.19%
==========================================
Files 28 29 +1
Lines 4047 4067 +20
==========================================
+ Hits 2574 2579 +5
- Misses 1173 1188 +15
Partials 300 300
🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+80
to
+84
| for owner, rows := range grouped { | ||
| if err := w.writePartition(version, owner, rows); err != nil { | ||
| return err | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Introduces a new
ParquetBackendfor thesspackage. This backend wraps an underlyingStateStore(e.g., PebbleDB) to delegate all read operations, maintaining MVCC performance. For state changes, it performs best-effort side-writes to Parquet files. These files are partitioned using HDFS-style partitioning byversion=<height>/owner=<owner>, designed to significantly acceleratedebug_traceand other analytical queries by enabling efficient data filtering.Testing performed to validate your change
Successfully built the project with the new
ParquetBackendand its dependencies.