This repository has been archived by the owner on Aug 16, 2023. It is now read-only.
When writing the diff file, Niffy does not wait for stream to close #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stream. We encountered this issue while adding an upload to S3 to our after phase. The file uploaded to S3 contained partial data; indicating that there was two process competing to write and read the file. Fix is a simple on close handler. We also bumped the version of pngjs. note: potential bug/omission found in pngjs https://github.com/lukeapage/pngjs/blob/master/lib/png.js#L43
alanpilloud
approved these changes
Apr 4, 2018
|
@fouad When do you plan to merge this PR ? We still have random truncated PNGs when uploading to S3 which is a bit problematic to see the diffs :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered this issue while adding an upload to S3 to our after phase.
The file uploaded to S3 contained partial data; indicating that there was multiple processes competing to write and read the file.
Fix is a simple on close handler used with thunkify.
We also bumped the version of pngjs.
Let us know what you think.
note: potential bug/omission found in pngjs. Will be filed.
https://github.com/lukeapage/pngjs/blob/master/lib/png.js#L43