feat: Refactor API uploadEvents function#971
Closed
matthieuMay wants to merge 1 commit intosegmentio:masterfrom
Closed
feat: Refactor API uploadEvents function#971matthieuMay wants to merge 1 commit intosegmentio:masterfrom
matthieuMay wants to merge 1 commit intosegmentio:masterfrom
Conversation
Contributor
|
@matthieuMay : Thanks for your suggestion. But the changes you proposed makes the code out of sync from other platforms which is not a good idea. Also, regarding documentation of Batch API, I would look into this again. Feel free to raise PR if you have other enhancements in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as suggested here: #961 (comment)
This greatly limits the size of the payloads sent
We have been using it in production for 3 weeks without any problem