Skip to content

Conversation

@joe-ayoub-segment
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment commented Oct 24, 2025

Adding new field for LinkedIn CAPI Destination.

Testing

Unit tests added.
Staging testing.

This payload was sent from Staging:

{
  "body": {
    "conversion": "urn:lla:llaPartnerConversion:19865954",
    "conversionHappenedAt": 1760069311909,
    "conversionValue": {
      "amount": "500",
      "currencyCode": "USD"
    },
    "eventId": "dsfds2342e32dwaeadfsd",
    "user": {
      "externalIds": [
        "this_is_an_external_id_1"
      ],
      "userIds": [
        {
          "idType": "SHA256_EMAIL",
          "idValue": "4e87732d3ec74784fdcf77c0e1c76e897916c57c2d44b613b0331d1c558ccb80"
        }
      ],
      "userInfo": {
        "firstName": "Jimmy",
        "lastName": "Joebob"
      }
    }
  },
  "headers": {
    "Accept": "*/*",
    "Accept-Encoding": "gzip,deflate",
    "Authorization": "REDACTED",
    "Content-Length": "401",
    "Content-Type": "application/json",
    "Host": "api.linkedin.com",
    "Linkedin-Version": "202505",
    "User-Agent": "REDACTED",
    "X-Restli-Protocol-Version": "2.0.0"
  }
}

with this 200 response:

{
  "body": "",
  "headers": {
    "Connection": "keep-alive",
    "Content-Length": "0",
    "Date": "Fri, 24 Oct 2025 13:28:52 GMT",
    "Location": "/conversionEvents/com.linkedin.restli.internal.client.ResponseImpl@1e62611b",
    "Nel": "{\"report_to\":\"network-errors\",\"max_age\":1296000,\"success_fraction\":0.00066,\"failure_fraction\":1,\"include_subdomains\":true}",
    "Report-To": "{\"group\":\"network-errors\",\"max_age\":2592000,\"endpoints\":[{\"url\":\"https://www.linkedin.com/li/rep\"}],\"include_subdomains\":true}",
    "Set-Cookie": "bcookie=\"v=2&4f580851-d57f-4af5-8736-a7cd417c3d63\"; domain=.linkedin.com; Path=/; Secure; Expires=Sat, 24-Oct-2026 13:28:52 GMT; SameSite=None; lidc=\"b=OB43:s=O:r=O:a=O:p=O:g=4036:u=587:x=1:i=1761312531:t=1761371766:v=2:sig=AQF_EbK-DpsgxYfB2V5giIMhZAPHcSu1\"",
    "X-Li-Fabric": "prod-lor1",
    "X-Li-Pop": "prod-lor1-x",
    "X-Li-Proto": "http/1.1",
    "X-Li-Route-Key": "\"b=OB43:s=O:r=O:a=O:p=O:g=4036:u=587:x=1:i=1761312531:t=1761371766:v=2:sig=AQF_EbK-DpsgxYfB2V5giIMhZAPHcSu1\"",
    "X-Li-Uuid": "AAZB54fOGzlzRBcByPizfQ==",
    "X-Restli-Id": "com.linkedin.restli.internal.client.ResponseImpl@1e62611b",
    "X-Restli-Protocol-Version": "2.0.0"
  }
}
image image

@joe-ayoub-segment joe-ayoub-segment requested a review from a team as a code owner October 24, 2025 12:52
@joe-ayoub-segment joe-ayoub-segment self-assigned this Oct 24, 2025
@joe-ayoub-segment joe-ayoub-segment changed the title [LinkedIn CAPI] - new externalIds field STRATCONN-6298 - [LinkedIn CAPI] - new externalIds field Oct 24, 2025
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.99%. Comparing base (ce524ca) to head (82a019d).

Files with missing lines Patch % Lines
...src/destinations/linkedin-conversions/api/index.ts 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3365      +/-   ##
==========================================
- Coverage   79.99%   79.99%   -0.01%     
==========================================
  Files        1207     1207              
  Lines       22315    22317       +2     
  Branches     4398     4401       +3     
==========================================
+ Hits        17851    17852       +1     
  Misses       3688     3688              
- Partials      776      777       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant