Skip to content

Conversation

@cieniawska
Copy link
Contributor

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@joe-ayoub-segment
Copy link
Contributor

Thanks for the PR @cieniawska - I'll review it in the next couple of days.

@joe-ayoub-segment
Copy link
Contributor

Hi @cieniawska I reviewed the PR and went ahead and made some changes to it.
Main thing is that I noticed that userId and anonymousId values were not being sent with the track() call.

I opened a new PR to include these changes: #3364

Please take a look and confirm if any additional changes are required to that PR. If they are needed, please raise a PR into that branch (please don't reopen this current PR).

Kind regards,
Joe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants