Skip to content

[MAIN] [STRATCONN-6205] : [first party dv360] added limit for membershipDurationDays to 540 #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

[MAIN] [STRATCONN-6205] : [first party dv360] added limit for membershipDurationDays to 540 #3347

merged 1 commit into from
Oct 28, 2025
+2 −2

Conversation

@Prithviraj-rathore-segment
Copy link
Contributor

@Prithviraj-rathore-segment Prithviraj-rathore-segment commented Oct 16, 2025 •
edited
Loading

JIRA

https://twilio-engineering.atlassian.net/browse/STRATCONN-6205

A summary of your pull request, including the what change you're making and why.

Description

  1. This PR includes changes for the description of membershipDurationDays to limit upto 540 .
  2. Google has changed the limit in new v4 version of first party dv360 .
    Code changes are done based on this comment
    https://twilio-engineering.atlassian.net/browse/STRATCONN-6205?focusedCommentId=1791928

Testing

Please find the testing done in staging environment .
Screenshot 2025-10-16 at 11 16 28 AM

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@Prithviraj-rathore-segment Prithviraj-rathore-segment changed the title STRATCONN-6205 first party dv360 added limit for membershipDurationDays to 540 [MAIN] [STRATCONN-6205] : [first party dv360] added limit for membershipDurationDays to 540 Oct 16, 2025
@Prithviraj-rathore-segment Prithviraj-rathore-segment marked this pull request as ready for review October 16, 2025 05:58
@Prithviraj-rathore-segment Prithviraj-rathore-segment requested a review from a team as a code owner October 16, 2025 05:58
abhandage
abhandage requested changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@abhandage abhandage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we test the proposed changes ?

@itsarijitray itsarijitray merged commit 99d4f67 into main Oct 28, 2025
15 checks passed
@itsarijitray itsarijitray deleted the STRATCONN-6205-first-party-dv360-membershipDurationDays branch October 28, 2025 06:01
@joe-ayoub-segment
Copy link
Contributor

deployed

1 similar comment
@joe-ayoub-segment
Copy link
Contributor

deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhandage abhandage abhandage approved these changes

@monutwilio monutwilio monutwilio approved these changes

@joe-ayoub-segment joe-ayoub-segment Awaiting requested review from joe-ayoub-segment

@itsarijitray itsarijitray Awaiting requested review from itsarijitray

Assignees

No one assigned

Labels

deploy:push mode:cloud not-partner-eng-review (cloud) Ready for Release team:segment

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Prithviraj-rathore-segment @joe-ayoub-segment @abhandage @monutwilio @itsarijitray