feat: add support for internal distribution flag in xcframework creation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new `allowInternalDistribution` flag to the command options, enabling the creation of xcframeworks containing information not suitable for public distribution. The flag is passed to the xcodebuild command when set, ensuring the xcframework is built with the appropriate configuration. Signed-off-by: ddrccw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building Factory xcframwork, I get some errors "Failed to build module 'Factory" when importing Factory in other project. I find that if there is arm64-apple-ios.swiftmodule in
Factory.xcframework/ios-arm64/Factory.framework/Modules/Factory.swiftmodulewhich can fix these errors, so I add this flagThis commit introduces a new
allowInternalDistributionflag to the command options, enabling the creation of xcframeworks containing information not suitable for public distribution. The flag is passed to the xcodebuild command when set, ensuring the xcframework is built with the appropriate configuration.