Skip to content

fix(ir): preserve geometry referencing Unknown/Unresolved colors during baking #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bkfunk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(ir): preserve geometry referencing Unknown/Unresolved colors during baking #65

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a20b00d
Fix: Handle Unknown and Unresolved colors during geometry baking (#19)
bkfunk Oct 14, 2025
f36398c
refactor(ir): query_mesh returns &mut MeshBuffer directly
bkfunk May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ir/src/part.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,9 @@ impl PartBufferBundleBuilder {
(ColorReference::Current | ColorReference::Complement, false) => {
Some(&mut self.uncolored_without_bfc_mesh)
}
(ColorReference::Color(_), _) => {
(ColorReference::Color(_) | ColorReference::Unknown(_) | ColorReference::Unresolved(_), _) => {
Some(self.colored_meshes.entry(group.clone()).or_default())
}
Copy link
Copy Markdown
Author

@bkfunk bkfunk May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — addressed in f36398c. query_mesh now returns &mut MeshBuffer directly, the call site is simplified accordingly, and the dead Skipping unknown color group_key branch is gone.

_ => None,
}
}

Expand Down
Loading