Skip to content

Conversation

@fbacall
Copy link
Contributor

@fbacall fbacall commented Nov 19, 2025

Fixes #2404

@fbacall fbacall requested review from Copilot and stuzart November 19, 2025 16:29
Copilot finished reviewing on behalf of fbacall November 19, 2025 16:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements automatic stripping of leading and trailing whitespace from publication abstracts to maintain data consistency and improve display quality across the application.

Key changes:

  • Added auto_strip_attributes :abstract to the Publication model to automatically strip whitespace on save
  • Created a one-time rake migration task to clean existing publication abstracts in the database
  • Added comprehensive test coverage for the new functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
app/models/publication.rb Added auto_strip_attributes :abstract directive and fixed indentation in the explicit_versioning block
test/unit/publication_test.rb Added three new tests covering direct save, nil handling, and PubMed metadata extraction scenarios
lib/tasks/seek_upgrades.rake Created strip_publication_abstracts migration task and registered it in the upgrade tasks list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stuzart stuzart added this to the 1.17.2 milestone Nov 25, 2025
@stuzart stuzart moved this to In review in SEEK 1.17.x Nov 25, 2025
@fbacall fbacall merged commit e07f753 into seek-1.17 Nov 26, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in SEEK 1.17.x Nov 26, 2025
@fbacall fbacall deleted the publication-abstract-trim branch November 26, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants