Upgrade lts - #26
Conversation
askoufis
left a comment
askoufis
left a comment
There was a problem hiding this comment.
Thanks for doing this! Just a bit of background, I wrote this with the help of the autoinc team while I was at SEEK for my industry placement, and it was my first foray into haskell, and I haven't really done much haskell since then, so I don't really have any strong opinions on how stuff should work, so feel free to upgrade/tweak things how you see fit.
| stackParams <- runExceptT . getStackParameters $ "test/valid.yaml" | ||
| let descriptions = fromRight' stackParams | ||
| let accountID = "478156153062" | ||
| let accountID = "478156153XXX" |
There was a problem hiding this comment.
Was this a real account ID? 😱 🤦
There was a problem hiding this comment.
No idea, it's been in there for a long time so hopefully it's all good. I only came across it because a recommit hook fired and said is was no es bueno. 😬
| @@ -1,9 +1,9 @@ | |||
| FROM ubuntu:14.04 | |||
| FROM ubuntu:16.04 | |||
There was a problem hiding this comment.
18.04 is even smaller. Hesitant to go to 20.04 though, too new.
There was a problem hiding this comment.
Yeah perhaps we should give it a go, we've avoided moving off 16.04 but here it would probably be fine.
2 participants
Welcome to the 21st century, evaporate! Most of the changes come from applying the stylish-haskell config we use for other internal projects to the whole project. All the function changes are to make the project compile with new LTSs.
The only thing I'm unsure about is the change to throwing instead of using
failI couldn't tell why it was using fail, and there isn't an instance for MonaFail for AWST.