fuzz: Extend block and transaction round trip tests #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcofleon
force-pushed
the
primitives-fuzz-test
branch
from
abc93c5 to
ba9941d
Compare
Contributor
|
Nice! Would splitting |
sedited
reviewed
Nov 24, 2025
Comment on lines
21
to
52
| let tx_count = block.transaction_count(); | ||
| assert_eq!(tx_count, block.transactions().count()); | ||
|
|
||
| for (i, tx) in block.transactions().enumerate().take(1000) { | ||
| if let Ok(indexed_tx) = block.transaction(i) { | ||
| assert_eq!(tx.txid(), indexed_tx.txid()); | ||
| } | ||
|
|
||
| assert_eq!(tx.inputs().count(), tx.input_count()); | ||
| assert_eq!(tx.outputs().count(), tx.output_count()); | ||
|
|
||
| for (j, input) in tx.inputs().enumerate().take(10) { | ||
| if let Ok(indexed_input) = tx.input(j) { | ||
| let op1 = input.outpoint(); | ||
| let op2 = indexed_input.outpoint(); | ||
| assert_eq!(op1.txid(), op2.txid()); | ||
| assert_eq!(op1.index(), op2.index()); | ||
| assert_eq!(op1.is_null(), op2.is_null()); | ||
| } | ||
| } | ||
|
|
||
| for (j, output) in tx.outputs().enumerate().take(10) { | ||
| if let Ok(indexed_output) = tx.output(j) { | ||
| assert_eq!(output.value(), indexed_output.value()); | ||
| assert_eq!( | ||
| output.script_pubkey().to_bytes(), | ||
| indexed_output.script_pubkey().to_bytes() | ||
| ); | ||
| } | ||
| } | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
I think it would be nicer to extend the existing roundtrip targets with these additional tests. Both just consume a byte string and it would be good to have both of them consume a robust corpus of both hand-rolled block data and fuzzer inputs.
Contributor
Author
There was a problem hiding this comment.
Thanks, this makes more sense. I've added the checks to the round trip tests and then simplified the tx extraction test to be a quick verification at the end of the block test. The more I looked at it, I think the previous version was a bit overkill.
Let me know what you guys think / if anything else can be added.
Add checks for iterator vs indexed access on inputs, outputs, and transactions.
marcofleon
force-pushed
the
primitives-fuzz-test
branch
from
ba9941d to
b7539ea
Compare
marcofleon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
kernel_primitivesfuzz target that tests the Rust wrapper around Bitcoin Core's block and transaction data structures.Here's the coverage report.