Skip to content

Commit

Permalink
Move dependencies to the gemspec and lock down versions.
Browse files Browse the repository at this point in the history
Development dependencies should go in the gemspec when using a Gemfile. Versions
are locked down to prevent failures creeping in as dependencies are updated (so
long as they play nice with semantic versioning). An example of this is the
minitest gem; see issue 164 (rubyzip#164).
  • Loading branch information
hainesr authored and simonoff committed Jul 23, 2014
1 parent 2f42434 commit 982b528
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
source 'https://rubygems.org'

gemspec
gem 'rake'
gem 'coveralls', :require => false
gem 'pry'
gem 'minitest'
4 changes: 4 additions & 0 deletions rubyzip.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,8 @@ spec = Gem::Specification.new do |s|
s.require_paths = ['lib']
s.license = 'BSD 2-Clause'
s.required_ruby_version = '>= 1.9.2'
s.add_development_dependency 'rake', '~> 10.3'
s.add_development_dependency 'pry', '~> 0.10'
s.add_development_dependency 'minitest', '~> 5.2.0'
s.add_development_dependency 'coveralls', '~> 0.7'
end

0 comments on commit 982b528

Please sign in to comment.