List and prompt #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not 100% working though
* Added positional test-cases to .ok-file * Arguments can now be passed with the ok-prompt * --pass-args removed (can't make it work 100% when args are passed both with bash-prompt and ok-prompt) * Fixed a bug (list did the same as list-prompt)
* Added _OK_VERBOSE environment variable * Fixed two bugs in color customization. Spaces can be added too * Added lines to the .ok-file for other customizations
* reviewed all comments * fixed a bug with line number 0 or starting with a 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big change in amounts code changed, but mostly to enable working with arguments more effectively. The base is the same:
pwddidn't change)I'm really interested what you think of this. I need some feedback first. I'm a bit uncertain about --quiet/--verbose options and the renaming to
ok.sh(however, I couldn't leave them unimplemented).So let me know what you think!