Some fixes #22
Merged
Some fixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
doekman
commented
Jan 25, 2020
doekman
commented
- works in zsh again
- ok-bash works with python 2 again (ok fails with python2 #20)
- fixed issue ok-bash sometimes fails to perform the list command #19
- fixed script, so shellcheck doesn't issue any warnings anymore
- fixed a bug, where sometimes ok-bash could exit the current shell
Fixed ok.sh:80: and :240: bad substitution in zshell bad substitution in zshell export "$x" works, but shellcheck complaints <https://github.com/koalaman/shellcheck/wiki/SC2163>, so now it's export "${x?}"
Never use exit in sourced scripts
Removed export of OK-variables when running ok-function, as it is the responsibility of the user to alter and export these variables.
Made escape-codes work with exporting functions (when running `declare -f ok`, the output became colored halfway)
shutil.get_terminal_size doesn't exist in python2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.