Unicode fix #15
Merged
Unicode fix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it on windows' git-bash by doing cd /tmp
git clone [email protected]:secretGeek/ok-bash.git
cd ok-bash/
git checkout origin/unicode-fix
. ok.sh
cd /mnt/Users/martylake/dev/secret-project
dev
okAnd it all looks good :) |
|
Awesome. Merge it Doeke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK, this should fix #14
I've tested with macOS (Python 2.7.16 and Python 3.7.3) and Debian Stretch (Python 2.7.13 and Python 3.5.3). Could you test Windows?
I also added some testing-files. It's still a bit of a mystery to me how encoding is supposed to work. I think it's save to say we want
.okfiles to be inUTF-8encoding.ok-show.pywill only complaint ifPYTHONIOENCODINGis set, and only with python 3. I could set this variable inok.sh.Thoughts?