added methods for CardDAV-implementation #2
Conversation
There was a problem hiding this comment.
Could be changed to if (!empty($config['root_dir']) && $config['plugins']['webdav']) {.
|
Hi, nice additions. There could be some improvements (only injecting needed services instead whole container for example). I will have a closer look soon. |
lduer
force-pushed
the
master
branch
2 times, most recently
from
fc5d79b to
b573ac8
Compare
composer: suggest the installation of gedmo/doctrine-extension
|
Any progress on this? |
|
@snc what is still needed before this can be merged? |
SabreDav/PrincipalBackend.php
Outdated
There was a problem hiding this comment.
Why not use $this->user_manager->findUsers() here?
There was a problem hiding this comment.
good argument :)
anyway, i'm seriously planning to improve the backends and upgraded v3-integrations (sabre-dav) in a few days.
There was a problem hiding this comment.
btw: I've detected your fork of my work just some seconds ago. nice work!
There was a problem hiding this comment.
take all you want ;-) Your work has been very usefull
There was a problem hiding this comment.
Where is this used? Can't find the param usage
merge all changes
I've updated the bundle to my needs. The my new implementations contain: