Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't find hidden property instead of the hiding property #1963

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Don't find hidden property instead of the hiding property #1963

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14ab9bc
Don't find hidden property instead of the hiding property
mspertus Sep 4, 2024
55237d6
Add test for IssueTypeResolver should resolve to non-hidden property …
mspertus Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Jint/Runtime/Interop/TypeResolver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,14 @@ internal bool TryFindMemberAccessor(
{
if (memberNameComparer.Equals(name, memberName))
{
// If one property hides another (e.g., by public new), the derived property is returned.
if (property is not null
&& p.DeclaringType is not null
&& property.DeclaringType is not null
&& property.DeclaringType.IsSubclassOf(p.DeclaringType))
{
continue;
}
property = p;
break;
}
Expand Down