Add 2h keepalive by default #853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firewall). Fix unused deprecation error given by new compilers.
Author
|
Fixes #854. New 0.1.x release is kindly requested if this PR is approved. |
Collaborator
|
Hi, and thanks for the PR. I wonder if we should also allow for the user to configure it via |
jxs
reviewed
May 18, 2021
jxs
added
the
waiting-on-reviewer
Author
|
If the 2 h default is not acceptable, I can certainly implement an API, please do suggest what kind of API would be preferable. To me, this feature itself is a must-have for public internet web servers. |
Collaborator
|
if you are on a rush, you can convert your warp filters to |
Author
|
Configurable solution available in #1075, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 2h keepalive by default to drop unused TCP sessions (e.g. behind a firewall).
Fix unused deprecation error given by new compilers.