Fix JSON structure, adjust to httr2 - #89
Merged
Merged
Conversation
Not sure when the structure changed, but needed to edit the JSON and also rename response to resp to avoid conflict with httr2 function. Recreated from PR #87 on top of devel to pick up the activitySince flaky-test fix, since the original PR branch predated that fix and its CI was failing on unrelated, already-resolved test flakiness. Co-authored-by: jwokaty <1744257+jwokaty@users.noreply.github.com> Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
develso CI runs against the fixedactivitySincetests instead of the pre-StabilizeactivitySince()for empty GitHub results and remove brittle recent-activity assertions #88 flaky live-GitHub-API assertions.type/identifiers/creators/titlesarray nesting) and renamesresponsetorespto avoid a naming conflict withhttr2::response.Original description from #87:
Why a new PR instead of updating #87
#87's branch was opened 2026-09-11, before
d110e06("Handle empty activitySince results", merged via #88) landed ondevel. All 4 of #87's CI failures were caused by that unrelated, now-fixed test flakiness — not by #87's own change, which only touchesR/newBiocPkgDOI.R. This PR is based on currentdevelso CI reflects only the actual change.Test plan
generateBiocPkgDOI()against DataCite test API, if credentials availableCloses #87 (superseded).
Co-authored-by: jwokaty 1744257+jwokaty@users.noreply.github.com
🤖 Generated with Claude Code