Skip to content
This repository was archived by the owner on Feb 4, 2026. It is now read-only.

feat: seamless subgraph#1

Draft
axelsly wants to merge 2 commits intomainfrom
base
Draft

feat: seamless subgraph#1
axelsly wants to merge 2 commits intomainfrom
base

Conversation

@axelsly
Copy link
Copy Markdown

@axelsly axelsly commented Oct 13, 2023

No description provided.

"PoolAddressesProviderRegistryAddress": "0x90C5055530C0465AbB077FA016a3699A3F53Ef99",
"PoolAddressesProviderRegistryStartBlock": 3318508,
"RewardsControllerAddress": "0x91Ac2FfF8CBeF5859eAA6DdA661feBd533cD3780",
"RewardsControllerStartBlock": 3789111
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this block number from? Should it be 3318629?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From each contract's deployment block number. I believe Ethereum deployment block numbers matched those, can take another look

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the RewardsController was deployed at block 3318629. Could you double check?

Copy link
Copy Markdown

@NouDaimon NouDaimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants