Skip Body Parsing if no Schema Specified #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abimaelmartell
requested review from
codetheweb,
itelo and
seveibar
as code owners
razor-x
reviewed
Dec 8, 2023
|
|
||
| if (isFormData && willValidateRequestBody) { | ||
| req.body = input.formData?.parse(req.body) | ||
| if (isFormData && willValidateRequestBody && input.formData) { |
There was a problem hiding this comment.
Can isFormData contain the check for non-empty form data?
There was a problem hiding this comment.
Yes, that would still work, the issue is that because of the ? conditional thing, when formData is undefined, we overwrite the req.body to undefined too.
There was a problem hiding this comment.
I think if you do const isFormData = Boolean(input.formData) && input.formData then you can still remove the .?
razor-x
approved these changes
Dec 8, 2023
seveibar
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result is undefined if you don't pass an schema