Make Sink and future-util optional

[stackinspector]

fixs #142

[sdroege]

Looks mostly good, thanks!

In addition to these comments, can you also clean up the commit history? Just push --force to this PR afterwards.

[sdroege]

Doesn't hurt to provide this always, and should make sure that both this and the Sink impl are covered by the tests and running on the CI

[sdroege]

I think apart from this one it's all ready

[sdroege]

The new function is already used by everything (e.g. the autobahn tests). Maybe you can change it so that the server uses Sink::send and the client the new function (together with a comment why this is done)

[stackinspector]

can you also clean up the commit history?

I prefer to keep the full history in my repo, even if merging my partner's code goes messy due to less experience. You can choose to squash and merge to avoid bringing those messy commits into the mainline.

[stackinspector]

btw If a new and better Sink API is introduced in the future, the name of the feature will be ambiguous. Perhaps a more appropriate name for the feature is futures-03-sink, as is customary in the async Rust ecosystem.

[sdroege]

btw If a new and better Sink API is introduced in the future, the name of the feature will be ambiguous. Perhaps a more appropriate name for the feature is futures-03-sink, as is customary in the async Rust ecosystem.

That sounds like a good idea

[sdroege]

I prefer to keep the full history in my repo, even if merging my partner's code goes messy due to less experience. You can choose to squash and merge to avoid bringing those messy commits into the mainline.

I've put a version with cleaned up history here: #144

Let me know if you want to change the commit message.

[sdroege]

Merged as part of #144