Fixes for SDMX 2.1 Structure Tests #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix hierarchical codelist's base type * fix handling of 406 response code and allow invalid-representation test to actually pass * fix error when request type parameter === 'structure'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes handling of 406 response code
During the execution of the
/codelist/agency/id/version (invalid representation query)test, 406 status is expected as per the spec. Yet, existing code was not handling this status properly which resulted in test execution error, despite the server under test responding with expected status.Fixes hierarchical codelist's base type
Although
HierarchicalCodelist(HC for short) is not extendingItemSchemebase type in the information model, it is still assumed by the REST spec that it will be a subject to item scheme queries. So, the test infrastructure attempts so select a random set ofHierarchyitems from HC and code fails to do so, because object which is used to enclose HC information is aMaintainableObjecttype. At the same time HC is listed as a member in theITEM_SCHEME_TYPESenumeration. So in order for the test code to be able to select random items of the HC, its info carrier object was changed toItemSchemeObjectFixes handling of 'structure' request type parameter
When
/structure/all/all/alltest is executed, the code attempted to select a random object from the workspace by thestructuretype. Call toSDMX_STRUCTURE_TYPE.fromRestResource(toRun.resource)resulted innullwhich in turn triggered the error by theworkspace.getRandomSdmxObjectOfType()function invocation with'Missing mandatory parameter \'structureType\''message. Because of this, child tests would also fail.Restructured the test code to execute only one of two possible condition branches (random by type VS any random from workspace).