Skip to content

ToString + FromString functions #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steiler merged 6 commits into from
Jan 9, 2026
+798 −29
Merged

ToString + FromString functions #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d300035
remove nil check - we want to know when there is a problem
alexandernorth Dec 9, 2025
15a1e51
update package of all files to sdcpb. Migrated and merged logic for f…
alexandernorth Dec 9, 2025
9eaf1ea
format go.mod
alexandernorth Dec 10, 2025
5b39ce2
remove ToYANGType()
alexandernorth Dec 11, 2025
3fe70d3
reorg
alexandernorth Dec 11, 2025
e46906a
Merge branch 'main' into feature/ToString-FromString-functions
steiler Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import "schema.proto";

package data;

option go_package = "github.com/sdcio/sdc-protos/sdcpb;schema_server";
option go_package = "github.com/sdcio/sdc-protos/sdcpb;sdcpb";

service DataServer {
// datastore
Expand Down
4 changes: 3 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
module github.com/sdcio/sdc-protos

go 1.23.9
go 1.24.0

require (
github.com/sdcio/logger v0.0.3
github.com/google/go-cmp v0.7.0
google.golang.org/grpc v1.75.1
google.golang.org/protobuf v1.36.9
)

require (
github.com/go-logr/logr v1.4.3 // indirect
golang.org/x/net v0.41.0 // indirect
golang.org/x/sys v0.33.0 // indirect
golang.org/x/text v0.26.0 // indirect
Expand Down
2 changes: 2 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/sdcio/logger v0.0.3 h1:IFUbObObGry+S8lHGwOQKKRxJSuOphgRU/hxVhOdMOM=
github.com/sdcio/logger v0.0.3/go.mod h1:yWaOxK/G6vszjg8tKZiMqiEjlZouHsjFME4zSk+SAEA=
go.opentelemetry.io/auto/sdk v1.1.0 h1:cH53jehLUN6UFLY71z+NDOiNJqDdPRaXzTel0sJySYA=
go.opentelemetry.io/auto/sdk v1.1.0/go.mod h1:3wSPjt5PWp2RhlCcmmOial7AvC4DQqZb7a7wCow3W8A=
go.opentelemetry.io/otel v1.37.0 h1:9zhNfelUvx0KBfu/gb+ZgeAfAgtWrfHJZcAqFC228wQ=
Expand Down
2 changes: 1 addition & 1 deletion schema.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ syntax = "proto3";

package schema;

option go_package = "github.com/sdcio/sdc-protos/sdcpb;schema_server";
option go_package = "github.com/sdcio/sdc-protos/sdcpb;sdcpb";

service SchemaServer {
// returns schema name, vendor, version, and files path(s)
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/blame_tree_element_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import (
"fmt"
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/choice_info_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

func (c *ChoiceInfo) GetChoiceByName(choiceName string) *ChoiceInfoChoice {
return c.Choice[choiceName]
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/choice_info_choice_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

func (c *ChoiceInfoChoice) GetAllAttributes() []string {
result := make([]string, 0, len(c.Case))
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/container_schema_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

func (x *ContainerSchema) GetMandatoryChildrenConfig() []*MandatoryChild {
var result []*MandatoryChild
Expand Down
7 changes: 4 additions & 3 deletions sdcpb/data.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion sdcpb/data_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdcpb/identityref_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import "fmt"

Expand Down
2 changes: 1 addition & 1 deletion sdcpb/path_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import (
"errors"
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/path_additions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import (
"testing"
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/path_elem.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import (
"iter"
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/path_set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import "iter"

Expand Down
2 changes: 1 addition & 1 deletion sdcpb/path_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package schema_server
package sdcpb

import (
"testing"
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/paths.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

type Paths []*Path

Expand Down
7 changes: 4 additions & 3 deletions sdcpb/schema.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdcpb/schema_elem_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

func (s *SchemaElem) IsState() bool {
switch x := s.Schema.(type) {
Expand Down
3 changes: 2 additions & 1 deletion sdcpb/schema_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdcpb/transaction_set_response_intent_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

func (t *TransactionSetResponseIntent) Failed() bool {
return len(t.Errors) > 0
Expand Down
2 changes: 1 addition & 1 deletion sdcpb/transactionsetresponse_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import "fmt"

Expand Down
5 changes: 1 addition & 4 deletions sdcpb/typed_value_additions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package schema_server
package sdcpb

import (
"bytes"
Expand Down Expand Up @@ -117,9 +117,6 @@ func toStringSorted(tvs []*TypedValue) []string {

// ToString converts the TypedValue to the real, non proto string
func (tv *TypedValue) ToString() string {
if tv == nil {
return ""
}
switch tv.Value.(type) {
case *TypedValue_AnyVal:
return string(tv.GetAnyVal().GetValue()) // questionable...
Expand Down
Loading