-
Notifications
You must be signed in to change notification settings - Fork 12
split config-server in apiserver and controller #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note: integration-tests needs to be adjusted in order to make the testing pipeline succeed (namespace change, deployment changes). Perhaps we can do that once the refactor PR has been merged. deployment also might need to be adjusted as there are 2 deployments right now. This need to be adjusted first before we apply the 'safe to test' label. |
https://github.com/sdcio/integration-tests/tree/feature/split-configserver has been prepared for this. |
|
@henderiw Running in debug mode this leads to issues for me. |
| apiVersion: v1 | ||
| fieldPath: status.hostIP | ||
| - name: LOCAL-DATASERVER | ||
| value: "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other variables use _ instead of -.
We should align this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed 60fc0dc
splitting the config server:
changed namespace to sdc-system by default.
need to find a solution for dry-run and get running config/configblame