Skip to content

Conversation

@henderiw
Copy link
Contributor

splitting the config server:

  • apiserver
  • controller

changed namespace to sdc-system by default.

need to find a solution for dry-run and get running config/configblame

@henderiw henderiw changed the title aplit config-server in apiserver and controller split config-server in apiserver and controller Nov 28, 2025
@hansthienpondt
Copy link
Contributor

Note: integration-tests needs to be adjusted in order to make the testing pipeline succeed (namespace change, deployment changes). Perhaps we can do that once the refactor PR has been merged.

deployment also might need to be adjusted as there are 2 deployments right now.

❯ kubectl get deployment -A
NAMESPACE            NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
cert-manager         cert-manager              1/1     1            1           23h
cert-manager         cert-manager-cainjector   1/1     1            1           23h
cert-manager         cert-manager-webhook      1/1     1            1           23h
kube-system          coredns                   2/2     2            2           23h
local-path-storage   local-path-provisioner    1/1     1            1           23h
sdc-system           api-server                1/1     1            1           23h
sdc-system           controller                1/1     1            1           23h

This need to be adjusted first before we apply the 'safe to test' label.

@hansthienpondt
Copy link
Contributor

Note: integration-tests needs to be adjusted in order to make the testing pipeline succeed (namespace change, deployment changes). Perhaps we can do that once the refactor PR has been merged.

deployment also might need to be adjusted as there are 2 deployments right now.

❯ kubectl get deployment -A
NAMESPACE            NAME                      READY   UP-TO-DATE   AVAILABLE   AGE
cert-manager         cert-manager              1/1     1            1           23h
cert-manager         cert-manager-cainjector   1/1     1            1           23h
cert-manager         cert-manager-webhook      1/1     1            1           23h
kube-system          coredns                   2/2     2            2           23h
local-path-storage   local-path-provisioner    1/1     1            1           23h
sdc-system           api-server                1/1     1            1           23h
sdc-system           controller                1/1     1            1           23h

This need to be adjusted first before we apply the 'safe to test' label.

https://github.com/sdcio/integration-tests/tree/feature/split-configserver has been prepared for this.

@steiler
Copy link
Contributor

steiler commented Dec 23, 2025

@henderiw
Can we either make the metrics port configurable or define different ports for api-server and controller.

Running in debug mode this leads to issues for me.

metricsServerOptions := metricsserver.Options{
		BindAddress:   ":8443",

apiVersion: v1
fieldPath: status.hostIP
- name: LOCAL-DATASERVER
value: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other variables use _ instead of -.
We should align this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 60fc0dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants