Skip to content

Conversation

@charliehowen
Copy link

This change is Review on Reviewable

@LucyWilcox
Copy link

Review status: 0 of 1 files reviewed at latest revision, 4 unresolved discussions.


frequency.py, line 12 [r1] (raw file):
You should put all of this picking bit into a function and the just comment out the function call instead of commenting out all of it.


frequency.py, line 31 [r1] (raw file):
You should search for the beginning and end of the book itself. There is some into stuff that you don't wan to count.


frequency.py, line 35 [r1] (raw file):
This should be down at the bottom of the file and probably in an if name equals main statement.


frequency.py, line 51 [r1] (raw file):
t and l aren't very good variable names.


Comments from the review on Reviewable.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants