Skip to content

Conversation

@umadesai
Copy link

@umadesai umadesai commented Mar 10, 2016

This change is Reviewable

@srli
Copy link

srli commented May 5, 2016

Review status: 0 of 14 files reviewed at latest revision, 6 unresolved discussions.


a discussion (no related file):
Nicely done, your code is beautifully written and easy to understand. I've made a few comments, please take a look.


whack_a_mole.py, line 26 [r4] (raw file):
You don't need to redefine white every single time.


whack_a_mole.py, line 27 [r4] (raw file):
You may want more descriptive terms instead of message. Since you're blitting several pieces of text to the screen, it would be a good idea to put these in a for loop.


whack_a_mole.py, line 182 [r4] (raw file):
Not sure what parent and child mean in this context. May want more in line comments to make this clear.


whack_a_mole_no_cv.py, line 36 [r4] (raw file):
Your view should be purely displaying things to the screen. Logic like this should be in the model.


whack_a_mole_no_cv.py, line 44 [r4] (raw file):
Same as above.


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants