Migrate to Rust 2024 edition #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gen` starts to be a reserved keyword in Rust 2024 edition, so it's better to avoid using it as a variable name. This will also allow us to migrate to Rust 2024 edition in the future without code changes.
This commit updates the Rust edition for the entire project from 2021 to 2024.
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project to Rust 2024 edition, updating all Cargo.toml files and adopting edition 2024 features including let-chain syntax and automatic import sorting improvements.
Key changes:
- Updated edition field from "2021" to "2024" across all package manifests
- Changed workspace resolver from version "2" to "3" in root Cargo.toml
- Refactored nested if-let patterns to use let-chain syntax (a Rust 2024 feature)
- Reordered imports to follow standard library conventions (std before external crates)
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scylla-cdc/Cargo.toml | Updated edition to 2024 |
| scylla-cdc-test-utils/Cargo.toml | Updated edition to 2024 |
| scylla-cdc-replicator/Cargo.toml | Updated edition to 2024 |
| scylla-cdc-printer/Cargo.toml | Updated edition to 2024 |
| Cargo.toml | Updated workspace resolver to version 3 |
| scylla-cdc/src/stream_reader.rs | Applied let-chain syntax and reordered imports |
| scylla-cdc/src/stream_generations.rs | Reordered imports, added trailing semicolon, and renamed variables for clarity |
| scylla-cdc/src/log_reader.rs | Applied let-chain syntax and reordered imports |
| scylla-cdc/src/e2e_tests.rs | Reordered imports and reformatted long strings |
| scylla-cdc/src/checkpoints.rs | Reordered imports and renamed variable |
| scylla-cdc/src/cdc_types.rs | Reordered imports |
| scylla-cdc-test-utils/src/lib.rs | Reordered imports and reformatted long strings |
| scylla-cdc-printer/src/printer.rs | Reordered imports |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
wprzytula
force-pushed
the
migrate-to-2024-edition
branch
from
11c9726 to
d4d0d82
Compare
Lorak-mmk
suggested changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's migrate to 2024 edition for improvements it brings.