Clean test helpers #392
Draft
Clean test helpers #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helper policy was used only in broken integration tests. This policy appears to be re-implementation of the driver FallthroughRetryPolicy. Why: who knows...
This helper policy was used only in broken integration tests. This policy appears to be re-implementation of the driver AllowListPolicy. At least here there is an explanation, that it was used to filter by last octet of IP address, instead of full IP address as the base policy. Still, we cannot use this policy as we lack support for custom policies. If it becomes necessary to have such filtering again, we can implement it at that point in time.
This is done to allow editor to properly recognize the types of the helper.ccmHelper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.