Skip to content

Conversation

@adespawn
Copy link
Contributor

@adespawn adespawn commented Jan 13, 2026

This commit extends the CI examples configuration to include support
for the Linux Arm with node 20 (oldest supported) and the current
(latest stable release). This is progress towards ensuring
driver support on other architectures beyond x86_64.

Progress towards: #292, #50

This commit extends the CI examples configuration to include support
for the Linux Arm with node 20 (oldest supported) and current
(latest stable release). This is a progress towards ensuring
the driver support on other architectures beyond x86_64.
@adespawn adespawn changed the title New integration tests targets Add linux arm to CI examples workflow. Jan 22, 2026
@adespawn adespawn changed the title Add linux arm to CI examples workflow. Add linux arm to CI examples workflow Jan 22, 2026
@adespawn
Copy link
Contributor Author

@wprzytula We may consider whether we want to have the current matrix (x64: node 20, 22, 24, current, arm: node 20, current) run for each commit.

This is already quite a few targets, and I did not see any failures that were specific to one node version (other than the napi memory problem). We may consider limiting the number of combinations we run for each commit (maybe 1-2 node versions for x64 and 1 for arm) and running the full matrix as part of the extended CI.

@adespawn
Copy link
Contributor Author

(other than the napi memory problem).

This may also be a good reason to extend the integration tests to run them in the extended CI on all supported node version (we run on node 20 for now)

@adespawn adespawn requested a review from wprzytula January 22, 2026 14:26
@adespawn
Copy link
Contributor Author

Reqesting review despite failing CI - this appears to be some problem on the GH side. Added CI passes, so I will re-run failing one closer to merging

@adespawn adespawn marked this pull request as ready for review January 22, 2026 14:27
@adespawn adespawn self-assigned this Jan 22, 2026
@adespawn adespawn added the Tests Very important label Jan 22, 2026
@adespawn adespawn added this to the 0.4.0 milestone Jan 22, 2026
@wprzytula
Copy link
Contributor

@wprzytula We may consider whether we want to have the current matrix (x64: node 20, 22, 24, current, arm: node 20, current) run for each commit.

This is already quite a few targets, and I did not see any failures that were specific to one node version (other than the napi memory problem). We may consider limiting the number of combinations we run for each commit (maybe 1-2 node versions for x64 and 1 for arm) and running the full matrix as part of the extended CI.

@adespawn Let's do that as discussed in person: a small number of (node, arch) pairs for the usual CI and a much richer set for the extended CI.

@wprzytula wprzytula removed their request for review January 22, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tests Very important

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants