Make make run-integration-test do not try to update rust
#406
+21
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is frustrating, we should not do it.
Lorak-mmk
requested changes
Dec 15, 2025
| @rm -rf /tmp/download-cassandra.ccm | ||
|
|
||
| run-test-integration-scylla: prepare-integration-test download-ccm-scylla-image | ||
| run-test-integration-scylla: .prepare-environment-update-aio-max-nr prepare-integration-test |
Contributor
There was a problem hiding this comment.
Do I understand correctly that it will still call prepare-integration-test, which is something that prepares the environment? What it does:
prepare-environment-install-libcwhich callsdpkgupdate-apt-cache-if-neededwhich callsapt-getinstall-valgrind-if-missingwhich callsapt
It is fine to check if required tools are installed, and error out if not, but lets not implicitly install them. Installing in separate target is fine. Can you remove prepare-integration-test from user-facing targets (such as run-test-integration-scylla)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is frustrating, we should not do it.
Fixes: #401
Pre-review checklist
I have implemented Rust unit tests for the features/changes introduced.I have enabled appropriate tests inMakefilein{SCYLLA,CASSANDRA}_(NO_VALGRIND_)TEST_FILTER.Fixes:annotations to PR description.