Change active_interval and idle_interval to std::time::Duration#36
Merged
Conversation
Previously these options accepted milliseconds from user. The new way is more idiomatic, user-friendly, and follows the AWS SDK API.
There was a problem hiding this comment.
Pull request overview
This PR updates the Alternator client configuration API to use std::time::Duration for active_interval and idle_interval (instead of u64 milliseconds), aligning the public API with more idiomatic Rust and AWS SDK patterns.
Changes:
- Replaced
active_interval/idle_intervalconfig fields and builder setters fromOption<u64>toOption<std::time::Duration>. - Updated LiveNodes refresh default constants from millisecond integers to
Durationconstants and removedDuration::from_millis(...)conversions. - Refreshed related doc comments to remove millisecond-specific wording and describe defaults in human terms.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/live_nodes.rs |
Switches refresh interval defaults and wiring to Duration directly. |
src/config.rs |
Updates the public config/builder API and stored extension fields to Duration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
m-szymon
approved these changes
Jun 5, 2026
lukaszg22
added a commit
to lukaszg22/alternator-rust-driver
that referenced
this pull request
Jun 5, 2026
Change milliseconds to std::time::Duration, following the change made in scylladb#36.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As decided in #33, changed
active_intervalandidle_intervalfields fromu64(milliseconds) to std::time::Duration.The new way is more idiomatic, user-friendly, and follows the AWS SDK API.