Rename config setting + Disable compression by default#34
Merged
Conversation
Merged
Copilot stopped reviewing on behalf of
wprzytula due to an error
May 27, 2026 11:58
wprzytula
requested changes
May 27, 2026
| /// | ||
| /// Removes unwanted headers from the given request | ||
| pub(crate) fn strip_headers(request: &mut Request) { | ||
| pub(crate) fn strip_request_from_headers(request: &mut Request) { |
Contributor
There was a problem hiding this comment.
🔧 The order is wrong. See the examples I found:
Example: "I need to strip the old paint from the cabinet."
Example: "The wind stripped the leaves from the trees."
wkkasztan
force-pushed
the
master
branch
2 times, most recently
from
f64fdfd to
38a9a2b
Compare
wprzytula
previously requested changes
May 27, 2026
m-szymon
requested changes
May 29, 2026
m-szymon
left a comment
m-szymon
left a comment
Collaborator
There was a problem hiding this comment.
Following other drivers we should call it optimize_headers (and headers_whitelist when we can customize the whitelist).
Comment on lines
-60
to
-61
| pub fn enforce_header_whitelist(&self) -> Option<bool> { | ||
| self.alternator_ext.enforce_header_whitelist |
Collaborator
There was a problem hiding this comment.
I think we should be consistent with other drivers:
| Driver | Option name | Custom whitelist |
|---|---|---|
| Java | withOptimizeHeaders(true) |
withHeadersWhitelist(List) |
| Python | optimize_headers=True |
headers_whitelist=frozenset |
| Go | WithOptimizeHeaders(true) |
N/A |
Collaborator
|
Please, resolve conflicts. |
lukaszg22
added a commit
to lukaszg22/alternator-rust-driver
that referenced
this pull request
Jun 3, 2026
Following the change in scylladb#34
m-szymon
approved these changes
Jun 5, 2026
| } | ||
|
|
||
| /// Before sending each request, strip them from headers that are not used by the Alternator. | ||
| /// Before sending each request, strip the headers from them which are not used by the Alternator. |
| } | ||
|
|
||
| /// Before sending each request, strip them from headers that are not used by the Alternator. | ||
| /// Before sending each request, strip the headers from them which are not used by the Alternator. |
| } | ||
|
|
||
| /// Before sending each request, strip them from headers that are not used by the Alternator. | ||
| /// Before sending each request, strip the headers from them which are not used by the Alternator. |
Comment on lines
+68
to
70
| pub fn optimize_headers(&self) -> Option<bool> { | ||
| self.alternator_ext.optimize_headers | ||
| } |
| /// - chooses an arbitrary aws region, as alternator doesn't require one | ||
| /// - does not use request compression | ||
| /// | ||
| /// Can be build using [AlternatorConfig] like so: |
m-szymon
requested changes
Jun 8, 2026
Collaborator
There was a problem hiding this comment.
Please take a look at correctness of comments.
E.g. the module-level comment at the top (tests/http_content/optimize_headers.rs:1-33) still has several grammar/style issues, for example:
follow specific header whitelisttherefore we in fact, need to strip themfirst 3 use the same set of driver calls
| /// By default: | ||
| /// - enables round-robin load balancing | ||
| /// - strips headers that are not used by the alternator from all requests | ||
| /// - chooses an arbitrary aws region, as alternator doesn't require one |
Collaborator
There was a problem hiding this comment.
This wording is a bit misleading. The client does not choose an arbitrary region; it sets a concrete default region. I would phrase this as "sets a default AWS region" instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client should disable request compression by default, as older Scylla versions do not support request compression.
Also,
enforce_header_whitelistconfig setting can be simplified tostrip_headers.