-
Notifications
You must be signed in to change notification settings - Fork 3
feat(docker tests): add L1 messages to testing #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frisitano
wants to merge
18
commits into
main
Choose a base branch
from
feat/anvil-test-contracts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+692
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests-issue-transactions
…/anvil-test-contracts
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces anvil state that is configured for testing.
The contract addresses can be found in the
.env
file. The state must be loaded into anvil using the--load-state
argument. The state contains 10 prefunded accounts derived from the mnemonic "test test test test/// test test test test test test test junk". The first prefunded account (0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266) was used to deploy all scroll contracts and as such, is the owner. The sequencer in the system config contract has been set to the signer address we use in the docker-compose testing stack.
L1 message testing uncovered a bunch of issues:
a. this seems to be due to a race condition when the payload building job is completed and a new job is already kicked off. ie we call Sequencer::handle_new_payload too late. we would need to process the l1 message counter directly when consuming it (ie in build_payload_attributes). however, I'm not sure this would work in all circumstances. assume we receive a block (sequenced by another node) and simultanously the node also starts sequencing. then the same could happen. to address all cases I think we need to make sure that the latest payload/block is fully processed before building a new payload
b. another problem uncovered by this: l2geth nodes rejected the block with duplicate L1 messages since L1 messages are not consecutive over block boundaries. however, RN accepted the block. we need to make sure we check not only for messages being consecutive within a block but also across blocks.