From/ToSQL instances for Word16, Word32, Word64 #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svobot
reviewed
Jan 7, 2025
theophile-scrive
force-pushed
the
from-to-sql-instances-word
branch
from
ffbc206 to
4d216e4
Compare
|
CI is busted:
|
svobot
approved these changes
Jan 7, 2025
|
This needs roundtrip tests. |
|
CI will work if you rebase. |
theophile-scrive
force-pushed
the
from-to-sql-instances-word
branch
2 times, most recently
from
49dd5b5 to
c1eecfd
Compare
arybczak
reviewed
Jan 8, 2025
theophile-scrive
force-pushed
the
from-to-sql-instances-word
branch
from
c1eecfd to
d2a154b
Compare
theophile-scrive
force-pushed
the
from-to-sql-instances-word
branch
from
d2a154b to
b468460
Compare
|
@arybczak Everything ok now? |
I would update the |
arybczak
reviewed
Jun 16, 2025
theophile-scrive
force-pushed
the
from-to-sql-instances-word
branch
from
b468460 to
cf98589
Compare
arybczak
approved these changes
Aug 22, 2025
| , nullTest td (u :: Int64) | ||
| , nullTest td (u :: Float) | ||
| , nullTest td (u :: Double) | ||
| , nullTest td (u :: Word16) |
There was a problem hiding this comment.
Can you move these a few lines down, i.e. after Word8?
| , putGetTest td 100 (u :: Int64) (==) | ||
| , putGetTest td 10000 (u :: Float) (==) | ||
| , putGetTest td 10000 (u :: Double) (==) | ||
| , putGetTest td 100 (u :: Word16) (==) |
There was a problem hiding this comment.
Can you move these a few lines down, i.e. after Word8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.