Type cancelOrder methodName parameter to method keys of Creep/PowerCreep
#282
+20
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
Currently
Creep.cancelOrder(andPowerCreep) accept any string as themethodNameto cancel. This can be more tightly typed as strings at are keys of methods (not data properties) in those types.A more accurate solution would be to enumerate all of the methods that register intents.
A few new lines in the tests file include one good and one bad call to
cancelOrder.Checklists
src/files notindex.d.tsnpm run compileto updateindex.d.ts