Use unique Name<T> type for names of creeps, rooms, spawns, etc #281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Description
Similar to the
Id<T>type, this PR distinguishes between non-interchangeable names (Creep.name,Spawn.name,Room.name, etc) using a unique tagged type.Also similar to the
Idtype, this adds a bit of annoyance when using explicit name constants, which I think is a worthwhile tradeoff for the safety from using the wrong strings to index the various lookups by name, etc.I opted to not type the
nameparameter to the variouscreate...()functions. The requested name for a new creep doesn't become aName<Creep>until there's aCreepfor it to be associated with on a later tick.Checklists
src/files notindex.d.tsnpm run compileto updateindex.d.ts