Skip to content

Conversation

DiamondMofeng
Copy link
Member

@DiamondMofeng DiamondMofeng commented Feb 2, 2025

In the javascript world, prototype can only be accessed from constructors. Adding prototype to these interfaces is invalid and wrong

Anyway, this may break something. Please merge this PR only if we are about to release a major update.

Checklists

  • Test passed
  • Coding style (indentation, etc)
  • Edits have been made to src/ files not index.d.ts
  • Run npm run compile to update index.d.ts

In the javascript world, `prototype` can only be accessed from constructors.
@tiennou
Copy link
Contributor

tiennou commented Feb 2, 2025

For the record, not seeing any breakage from that here, and that's ~120 prototyped functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants