- 
                Notifications
    You must be signed in to change notification settings 
- Fork 106
Remove Python 2.7 and 3.5 support, add Python 3.9 support #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report
 
 @@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
- Coverage   95.45%   94.40%   -1.05%     
==========================================
  Files           7        7              
  Lines         484      465      -19     
  Branches       99       92       -7     
==========================================
- Hits          462      439      -23     
- Misses         15       16       +1     
- Partials        7       10       +3     
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the tests/py3-ignores.txt file used?
It was created in 2014. I see there was a similar file in Scrapy (scrapy/scrapy@350aa67), but it was used in the conftest. Where is this file used in this project? Could we remove it on this PR or do you prefer to open a new PR?
Once merged, we can also merge #167
To do:
tests/py3-ignores.txtuprefix in literal strings