Skip to content

async support for callback_for #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: integration for web-poet's support on additional requests and Meta
merged 15 commits into from
May 27, 2022
Merged

async support for callback_for #66

merged 15 commits into from
May 27, 2022

Conversation

@BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Mar 16, 2022 •
edited
Loading

Fixes #65. This PR's branch is built on top of #62 following async/await support on Page Objects.

Progress:

  • Tests
  • Update doc tutorial mentioning callback_for

@BurnzZ BurnzZ self-assigned this Mar 16, 2022
@BurnzZ BurnzZ changed the base branch from master to po-additional-requests March 16, 2022 05:58
@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (po-additional-requests@ae4d8a5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 45e9241 differs from pull request most recent head c2bfe89. Consider uploading reports for the commit c2bfe89 to get more accurate results

@@                    Coverage Diff                    @@
##             po-additional-requests      #66   +/-   ##
=========================================================
  Coverage                          ?   96.34%           
=========================================================
  Files                             ?       10           
  Lines                             ?      410           
  Branches                          ?        0           
=========================================================
  Hits                              ?      395           
  Misses                            ?       15           
  Partials                          ?        0

@BurnzZ BurnzZ marked this pull request as ready for review March 16, 2022 08:35
@BurnzZ BurnzZ requested a review from kmike March 16, 2022 08:35
@BurnzZ BurnzZ changed the title async support for callback_for async support for callback_for Mar 16, 2022
proway2
proway2 reviewed Mar 17, 2022
View reviewed changes
@BurnzZ BurnzZ force-pushed the po-additional-requests branch from 5eca70e to 8340ced Compare March 29, 2022 03:19
@BurnzZ BurnzZ force-pushed the async_callback_for branch from 186f0a7 to a74d264 Compare March 29, 2022 04:50
Gallaecio
Gallaecio reviewed May 26, 2022
View reviewed changes
@BurnzZ BurnzZ mentioned this pull request May 27, 2022
Merged
3 tasks
Gallaecio
Gallaecio approved these changes May 27, 2022
View reviewed changes
gatufo
gatufo approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@gatufo gatufo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmike kmike merged commit 10b56e3 into po-additional-requests May 27, 2022
@kmike
Copy link
Member

kmike commented May 27, 2022

Thanks @BurnzZ!

@BurnzZ BurnzZ deleted the async_callback_for branch October 14, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@gatufo gatufo gatufo approved these changes

@kmike kmike Awaiting requested review from kmike

+1 more reviewer

@proway2 proway2 proway2 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@BurnzZ BurnzZ

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

callback_for does not produce a coroutine.

5 participants

@BurnzZ @kmike @Gallaecio @gatufo @proway2