Update test expectations for a future where web_poet.pages.is_injectable(type(None)) is False #218
Conversation
Gallaecio
changed the title
| class OptionalAndUnionPage(WebPage): | ||
| class OptionalAndUnionPageNew(WebPage): | ||
| breadcrumbs: BreadcrumbsExtraction | ||
| opt_check_1: Optional[BreadcrumbsExtraction] |
There was a problem hiding this comment.
Just in case, could you please add a test which checks that in case of Optional[something] things don't break if something is not available? There are similar tests in test_optional_and_unions_old, but not exactly that.
There was a problem hiding this comment.
Great catch. If it’s not injectable, that indeed causes an issue, I need to figure out a solution for that. It might have to do with attrs’ attribute default values not being recognized by andi, because I don’t think it happens for default values in regular callables (e.g. Scrapy callbacks).
not available
Did you mean not injectable, or should we also support scenarios where a bad type hint is provided? (e.g. var1: "UnexistingType" or var2: "Optional[UnexistingType]")
There was a problem hiding this comment.
Tests updated, and issue addressed by scrapinghub/andi#33.
…table type even when there is a default value
To do:
Fix the issue.(the issue is in web-poet: Do not consider type(None) injectable web-poet#212)