Enable HttpRequestProvider by default (#195)

scrapinghub · Apr 24, 2024 · 6d3bd0c · 6d3bd0c
1 parent 33884cf
commit 6d3bd0c
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/scrapy_poet/downloadermiddlewares.py b/scrapy_poet/downloadermiddlewares.py
@@ -18,6 +18,7 @@
 from .injection import Injector
 from .page_input_providers import (
     HttpClientProvider,
+    HttpRequestProvider,
     HttpResponseProvider,
     PageParamsProvider,
     RequestUrlProvider,
@@ -39,6 +40,7 @@ def process_response(
 
 
 DEFAULT_PROVIDERS = {
+    HttpRequestProvider: 400,
     HttpResponseProvider: 500,
     HttpClientProvider: 600,
     PageParamsProvider: 700,

diff --git a/tests/test_page_input_providers.py b/tests/test_page_input_providers.py
@@ -1,6 +1,7 @@
 import pytest
 
-from scrapy_poet import PageObjectInputProvider
+from scrapy_poet import PageObjectInputProvider, page_input_providers
+from scrapy_poet.downloadermiddlewares import DEFAULT_PROVIDERS
 from scrapy_poet.injection_errors import MalformedProvidedClassesError
 
 
@@ -38,3 +39,19 @@ class Provider(PageObjectInputProvider):
         assert provider.is_provided(str)
         assert provider.is_provided(int)
         assert not provider.is_provided(float)
+
+
+def test_default_providers():
+    providers = {
+        obj
+        for obj_name, obj in page_input_providers.__dict__.items()
+        if (
+            obj_name.endswith("Provider")
+            and obj_name
+            not in {
+                "ItemProvider",  # Deprecated
+                "PageObjectInputProvider",  # Base class
+            }
+        )
+    }
+    assert providers == set(DEFAULT_PROVIDERS)