-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring VcrGzipSerializer to normalize new cassettes #112
Refactoring VcrGzipSerializer to normalize new cassettes #112
Conversation
Codecov Report
@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 28 28
Lines 1895 1895
=======================================
Hits 1774 1774
Misses 121 121 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victor-torres That's a very neat idea. Sorry for taking so long to review it, I was continuously failing to allocate enough time to check it carefully and test locally as required. Could you take a quick look into the comments pls?
Thank you for your comments here, @vshlapakov. I'm just waiting for some time before jumping into this PR again. |
now you should be able to add new cassettes easier than before I should update the readme file with more infor about it
e0f4082
to
0f10269
Compare
@vshlapakov I've just updated the pull request. Easy way to test the feature: Rename some test case, for example, Execute the test command specifying the environment variables (you can use any dummy Scrapy Cloud project):
Check the new cassette file
|
That's just awesome, thank you so much 👏 |
With these changes, it would be easier to add new cassettes when adding new tests and making calls to HubStorage and Dash APIs.
For example, you can use a dummy Scrapy Cloud project and its deploy API Key to add a new test cassette as following:
This will use the production servers with the provided credentials and will create a new cassette file at
tests/client/cassettes/test_collections/test_new_case.gz
.From now on you can execute the test with just: